datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[backport] fix flaky eventlog integration tests (#22140)

Open clarkb7 opened this issue 1 year ago • 1 comments

What does this PR do?

backport https://github.com/DataDog/datadog-agent/pull/22140 as a pre-req for https://github.com/DataDog/datadog-agent/pull/22923

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

clarkb7 avatar Feb 16 '24 19:02 clarkb7

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8bf0832b-ef70-49ec-b4f6-faf696eb29fa Baseline: 71cc7a8df373c18b93a54c5524ed72540228afb7 Comparison: 0a95f6db02eae20f7ce3b1feb0f46a85a2bbcdb1 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.43 [+0.34, +0.52]
file_to_blackhole % cpu utilization +0.27 [-6.27, +6.80]
idle memory utilization -0.09 [-0.11, -0.06]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +2.53 [+1.78, +3.27]
tcp_syslog_to_blackhole ingress throughput +0.64 [+0.58, +0.70]
process_agent_standard_check memory utilization +0.60 [+0.54, +0.65]
process_agent_standard_check_with_stats memory utilization +0.51 [+0.46, +0.55]
file_tree memory utilization +0.43 [+0.34, +0.52]
file_to_blackhole % cpu utilization +0.27 [-6.27, +6.80]
trace_agent_msgpack ingress throughput +0.06 [+0.04, +0.08]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.06, +0.06]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.03, +0.03]
process_agent_real_time_mode memory utilization -0.00 [-0.04, +0.03]
trace_agent_json ingress throughput -0.07 [-0.10, -0.04]
idle memory utilization -0.09 [-0.11, -0.06]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 20 '24 19:02 pr-commenter[bot]

/merge

clarkb7 avatar Feb 21 '24 21:02 clarkb7

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 21 '24 21:02 dd-devflow[bot]