datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Adding release note for the Fleet Automation fixes

Open hush-hush opened this issue 1 year ago • 1 comments

What does this PR do?

Adding release note for the Fleet Automation fixes

This covers the following PRs:

  • #22773
  • #22651
  • #22411
  • #22442
  • #22132

Describe how to test/QA your changes

QA for ASC:

  • Deploy the agent on a normal host and check that the metadata payload correctly reflect the configuration (use: datadog-agent diagnose show-metadata inventory-agent)
  • Then deploy it on k8s with our official helm chart, while enabling all product, and check the metadata is correct.

Feel free to sync with other teams involved in the QA of the PRs listed above on how to enable each product.

hush-hush avatar Feb 16 '24 15:02 hush-hush

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: f6e9b4ad-695e-4bb6-a737-aa07dbada1f8 Baseline: 3c1871919b4e6d4e4c3817d7a2b227f960d5e0e0 Comparison: 535ce665363042d0c7a4c7ab10c2a2c301d4eab5 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.02 [-6.57, +6.53]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.92 [+0.29, +1.55]
idle memory utilization +0.29 [+0.25, +0.33]
tcp_syslog_to_blackhole ingress throughput +0.26 [+0.21, +0.32]
trace_agent_msgpack ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.02 [-0.04, +0.00]
file_to_blackhole % cpu utilization -0.02 [-6.57, +6.53]
process_agent_standard_check_with_stats memory utilization -0.22 [-0.28, -0.17]
process_agent_standard_check memory utilization -0.34 [-0.40, -0.29]
process_agent_real_time_mode memory utilization -0.46 [-0.51, -0.41]
file_tree memory utilization -0.60 [-0.68, -0.51]
uds_dogstatsd_to_api_cpu % cpu utilization -2.28 [-3.69, -0.88]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 16 '24 16:02 pr-commenter[bot]

/merge

hush-hush avatar Feb 21 '24 10:02 hush-hush

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 21 '24 10:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

This build is going to start soon! (estimated merge in less than 47m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 21 '24 10:02 dd-devflow[bot]