datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Use Go bugfix version in go.mod directives

Open pgimalac opened this issue 1 year ago • 7 comments

What does this PR do?

Update all go.mod files to use the bugfix Go version (1.21.7) instead of the minor version (1.21).

Motivation

It is preventing importing dependencies with a bugfix version set (ie. we can't import a dependency using 1.21.0 for example, this is forcing us to add the bugfix)

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Feb 16 '24 11:02 pgimalac

Should we update the docker files and the other places we reference 1.21?

GustavoCaso avatar Feb 16 '24 12:02 GustavoCaso

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 005ee896-217f-46b2-9200-da3eb38f8ee0 Baseline: fced5cf5c89d4e379117224aa019434ac5e58375 Comparison: f1b5888aa48ea06a9e8dc285c854602317bbd5a0 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.05 [-6.62, +6.51]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.63 [+0.19, +3.06]
tcp_syslog_to_blackhole ingress throughput +0.42 [+0.36, +0.48]
process_agent_standard_check memory utilization +0.23 [+0.20, +0.27]
otel_to_otel_logs ingress throughput +0.20 [-0.41, +0.82]
trace_agent_json ingress throughput +0.05 [+0.01, +0.08]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
file_tree memory utilization -0.03 [-0.11, +0.04]
file_to_blackhole % cpu utilization -0.05 [-6.62, +6.51]
idle memory utilization -0.08 [-0.11, -0.04]
process_agent_real_time_mode memory utilization -0.14 [-0.17, -0.11]
process_agent_standard_check_with_stats memory utilization -0.37 [-0.40, -0.33]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 16 '24 13:02 pr-commenter[bot]

/merge

pgimalac avatar Feb 16 '24 16:02 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 16:02 dd-devflow[bot]

:x: MergeQueue

Tests failed on this commit cc1ac31

You should fix those tests and then re-add your pull request to the queue!

Details

some checks are failing:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 16 '24 18:02 dd-devflow[bot]

I think this is failing because https://github.com/DataDog/datadog-lambda-extension/blob/23357637625a986f53bdc218c43c9c52656156d5/scripts/Dockerfile.alpine.build#L10 is still using Go 1.20, which cannot parse go 1.21.7 from the go.mod: go.mod:3: invalid go version '1.21.7': must match format 1.23

brycekahle avatar Feb 16 '24 22:02 brycekahle

Thanks @brycekahle I believe you are right, I opened a PR in that repo to bump the Go version 👍

pgimalac avatar Feb 19 '24 13:02 pgimalac

/merge

pgimalac avatar Feb 26 '24 16:02 pgimalac

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 11 builds ahead! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 16:02 dd-devflow[bot]