datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

bump cilium/ebpf to v0.13.0

Open paulcacheux opened this issue 1 year ago • 4 comments

What does this PR do?

This new release includes lot of performance improvements, especially around btf copying https://github.com/cilium/ebpf/releases/tag/v0.13.0

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Feb 16 '24 08:02 paulcacheux

Go Package Import Differences

Baseline: e0749a853131cbe757fc611fcf96ac016f89dde5 Comparison: 69a54800492e4828d3b18cdf6f97fc0563f5c7d7

binaryosarchchange
agentlinuxamd64
+1, -0
+maps
agentlinuxarm64
+1, -0
+maps
iot-agentlinuxamd64
+1, -0
+maps
iot-agentlinuxarm64
+1, -0
+maps
heroku-agentlinuxamd64
+1, -0
+maps
cluster-agentlinuxamd64
+1, -0
+maps
cluster-agentlinuxarm64
+1, -0
+maps
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+maps
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+maps
process-agentlinuxamd64
+1, -0
+maps
process-agentlinuxarm64
+1, -0
+maps
heroku-process-agentlinuxamd64
+1, -0
+maps
security-agentlinuxamd64
+1, -0
+maps
security-agentlinuxarm64
+1, -0
+maps
system-probelinuxamd64
+1, -0
+maps
system-probelinuxarm64
+1, -0
+maps

cit-pr-commenter[bot] avatar Feb 16 '24 22:02 cit-pr-commenter[bot]

@paulcacheux I included the manager update as well. Feel free to revert if you don't want it.

brycekahle avatar Feb 16 '24 22:02 brycekahle

Waiting on https://github.com/DataDog/datadog-agent/pull/22908

brycekahle avatar Feb 16 '24 22:02 brycekahle

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 779a84d5-8de7-442b-9fe8-2cf49bd1745e Baseline: e0749a853131cbe757fc611fcf96ac016f89dde5 Comparison: 69a54800492e4828d3b18cdf6f97fc0563f5c7d7 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.06 [-6.60, +6.49]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.78 [+1.14, +2.41]
uds_dogstatsd_to_api_cpu % cpu utilization +1.23 [-0.19, +2.64]
idle memory utilization +0.51 [+0.47, +0.54]
tcp_syslog_to_blackhole ingress throughput +0.45 [+0.39, +0.51]
process_agent_standard_check memory utilization +0.07 [+0.04, +0.11]
trace_agent_json ingress throughput +0.06 [+0.02, +0.10]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.05 [-0.09, -0.01]
file_to_blackhole % cpu utilization -0.06 [-6.60, +6.49]
process_agent_standard_check_with_stats memory utilization -0.08 [-0.11, -0.05]
file_tree memory utilization -1.45 [-1.52, -1.37]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 16 '24 23:02 pr-commenter[bot]

/merge

paulcacheux avatar Feb 28 '24 07:02 paulcacheux

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 07:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 28 '24 09:02 dd-devflow[bot]