datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

workloadmeta performance tuning

Open keisku opened this issue 1 year ago • 1 comments

What does this PR do?

  • Make (*workloadmeta).Notify() non-blocking.
  • Make (*workloadmeta).handleEvents() run in parallel.

Motivation

See CONS-6149

"workloadmeta-store" and "ad-kubeletlistener" become unhealthy status frequently in a cluster where many CronJob that spawns short-lieved container exists.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

keisku avatar Feb 16 '24 06:02 keisku

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6469a539-c553-404f-bd0d-f31f385cc717 Baseline: 294ae46153c39545b7e9517a65fed146f50827fb Comparison: 66a515f9bafd1569a213a9a1fce4bc66354f43ad Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.13 [-6.44, +6.69]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_standard_check memory utilization +0.26 [+0.22, +0.30]
file_to_blackhole % cpu utilization +0.13 [-6.44, +6.69]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, -0.00]
trace_agent_json ingress throughput -0.05 [-0.08, -0.01]
tcp_syslog_to_blackhole ingress throughput -0.05 [-0.11, +0.00]
process_agent_standard_check_with_stats memory utilization -0.09 [-0.13, -0.06]
uds_dogstatsd_to_api_cpu % cpu utilization -0.10 [-1.52, +1.32]
idle memory utilization -0.13 [-0.17, -0.10]
otel_to_otel_logs ingress throughput -0.43 [-1.06, +0.21]
process_agent_real_time_mode memory utilization -0.78 [-0.82, -0.75]
file_tree memory utilization -0.82 [-0.89, -0.74]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 16 '24 08:02 pr-commenter[bot]