datadog-agent
datadog-agent copied to clipboard
[Serverless] Upgrade from deprecated nodejs14.x
What does this PR do?
Replace deprecated nodejs14.x runtime with nodejs18.x
Motivation
This causes the serverless integration tests to fail and is blocking merges.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove
command.
Use /merge -c
to cancel this operation!
:steam_locomotive: MergeQueue
Added to the queue.
This build is next! (estimated merge in less than 48m)
Use /merge -c
to cancel this operation!
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 826a5cdb-b06c-4eb4-8fb1-b41201893e39 Baseline: 50ca618fbe1e90dc644c087b4e9ce041da0a4f15 Comparison: 4cac3d3ea729a40aaf37abf301147a5787791e75 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +0.04 | [-6.52, +6.60] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | process_agent_real_time_mode | memory utilization | +0.85 | [+0.82, +0.88] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.66 | [+0.60, +0.72] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.55 | [+0.52, +0.59] |
➖ | idle | memory utilization | +0.06 | [+0.02, +0.09] |
➖ | file_to_blackhole | % cpu utilization | +0.04 | [-6.52, +6.60] |
➖ | process_agent_standard_check | memory utilization | +0.03 | [-0.01, +0.08] |
➖ | file_tree | memory utilization | +0.03 | [-0.05, +0.10] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.02 | [-1.38, +1.42] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.03, +0.02] |
➖ | trace_agent_msgpack | ingress throughput | -0.01 | [-0.03, +0.00] |
➖ | otel_to_otel_logs | ingress throughput | -1.11 | [-1.70, -0.52] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".