datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

event monitor: allow configuring socket path on windows

Open paulcacheux opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

The event monitor socket path is currently hardcoded and not configurable, this PR makes it configurable. The end goal is to give the possibility of free-ing the port 3335 if needed.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Feb 15 '24 19:02 paulcacheux

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 96416975-6594-434d-a784-8400197fde19 Baseline: a164c948ea2f03672d1374293f938d284d8b1e28 Comparison: da812a91aec4ac5b3283fd520a0a082a98bc6afb Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.16 [-4.54, +8.86]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.16 [-4.54, +8.86]
idle memory utilization +0.45 [+0.42, +0.48]
process_agent_standard_check_with_stats memory utilization +0.32 [+0.28, +0.35]
trace_agent_json ingress throughput +0.00 [-0.03, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.02 [-0.04, -0.01]
process_agent_standard_check memory utilization -0.28 [-0.32, -0.24]
file_tree memory utilization -0.59 [-0.68, -0.49]
process_agent_real_time_mode memory utilization -0.86 [-0.90, -0.82]
otel_to_otel_logs ingress throughput -0.97 [-1.57, -0.38]
tcp_syslog_to_blackhole ingress throughput -1.00 [-1.07, -0.93]
uds_dogstatsd_to_api_cpu % cpu utilization -3.76 [-5.16, -2.35]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 15 '24 21:02 pr-commenter[bot]

/merge

paulcacheux avatar Feb 16 '24 08:02 paulcacheux

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 08:02 dd-devflow[bot]