datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[e2e] bump test-infra-definitions

Open pducolin opened this issue 1 year ago • 1 comments

What does this PR do?

Bump test-infra-definitions

Motivation

Many changes in the changelog, https://github.com/DataDog/test-infra-definitions/commit/e2cab94dc39f6e4b8aa53a0ac81648e432eb34e1 should reduce flakiness in e2e tests at agent install, as sometimes S3 returns an SSL error, and AWS recommends retrying as a solution

Additional Notes

Changelog: https://github.com/DataDog/test-infra-definitions/compare/6ba25fcf6a61...ee108d1a9355

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pducolin avatar Feb 15 '24 18:02 pducolin

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8256556a-9f64-4a87-9caa-910a6e260bf8 Baseline: 6583d8fbdc7e1d38b9f676a62689ce9445e62f8e Comparison: 59513db250a9e2d2d2ebfe2aa62235f690c95749 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.55 [-8.04, +4.93]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.78 [-0.65, +2.20]
process_agent_standard_check memory utilization +0.34 [+0.30, +0.38]
process_agent_standard_check_with_stats memory utilization +0.16 [+0.12, +0.19]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_syslog_to_blackhole ingress throughput -0.00 [-0.07, +0.06]
trace_agent_json ingress throughput -0.01 [-0.03, +0.02]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.00]
process_agent_real_time_mode memory utilization -0.13 [-0.17, -0.08]
idle memory utilization -0.18 [-0.21, -0.15]
otel_to_otel_logs ingress throughput -0.31 [-0.95, +0.32]
file_tree memory utilization -0.44 [-0.52, -0.36]
file_to_blackhole % cpu utilization -1.55 [-8.04, +4.93]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 15 '24 19:02 pr-commenter[bot]

Bump covered by https://github.com/DataDog/datadog-agent/pull/22894

pducolin avatar Feb 16 '24 08:02 pducolin