datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[gitlab] Fix e2e_installer_test_junit_upload job never running

Open KSerrania opened this issue 1 year ago • 1 comments

What does this PR do?

Updates the rules of the e2e_installer_test_junit_upload so that it actually runs.

Motivation

The current rules:

  rules:
    - !reference [.except_mergequeue]

expand to:

  rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never

which means the job is never run.

Additional Notes

n/a

Possible Drawbacks / Trade-offs

Check the presence of e2e_installer_test_junit_upload on the PR pipeline.

Describe how to test/QA your changes

KSerrania avatar Feb 15 '24 17:02 KSerrania

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ad25d995-383c-4ef4-9963-0f6cd37acf9a Baseline: 21213ac863f4c6c5c430f4f93f76810788b27820 Comparison: 464e3ede76c98a0b0d0c678d2b7e6ec0a5e91735 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.10 [-7.60, +5.39]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.27 [+0.25, +0.30]
process_agent_standard_check memory utilization +0.16 [+0.10, +0.21]
process_agent_real_time_mode memory utilization +0.13 [+0.09, +0.16]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
tcp_syslog_to_blackhole ingress throughput +0.01 [-0.04, +0.07]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.03, +0.02]
process_agent_standard_check_with_stats memory utilization -0.04 [-0.09, +0.01]
file_tree memory utilization -0.34 [-0.45, -0.22]
otel_to_otel_logs ingress throughput -0.49 [-1.09, +0.11]
file_to_blackhole % cpu utilization -1.10 [-7.60, +5.39]
uds_dogstatsd_to_api_cpu % cpu utilization -1.89 [-3.27, -0.51]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 15 '24 18:02 pr-commenter[bot]

/merge

chouetz avatar Feb 16 '24 08:02 chouetz

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 08:02 dd-devflow[bot]