datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CI] Run MacOS build job only on main, release branches and omnibus changes

Open amenasria opened this issue 1 year ago • 1 comments

What does this PR do?

This PR makes MacOS build job only run on main, release branches and omnibus/ changes.

Motivation

Reduce the MacOS runners load to avoid running out of runners on Github Actions.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

amenasria avatar Feb 15 '24 16:02 amenasria

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ab143630-c788-4a5f-b04d-d2dd75156b0e Baseline: 091536ce2affeb146584d17a319ab9a5103c7ea9 Comparison: 62d91d18cef7b11db07757b27d1c08d5331ca8ae Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.13 [-5.47, +7.72]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.13 [-5.47, +7.72]
tcp_syslog_to_blackhole ingress throughput +0.85 [+0.79, +0.90]
process_agent_real_time_mode memory utilization +0.42 [+0.37, +0.46]
uds_dogstatsd_to_api_cpu % cpu utilization +0.24 [-1.21, +1.69]
process_agent_standard_check_with_stats memory utilization +0.09 [+0.04, +0.14]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.04, +0.03]
idle memory utilization -0.28 [-0.32, -0.23]
process_agent_standard_check memory utilization -0.31 [-0.37, -0.25]
file_tree memory utilization -0.52 [-0.61, -0.43]
otel_to_otel_logs ingress throughput -1.26 [-1.88, -0.64]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 15 '24 18:02 pr-commenter[bot]

/merge

amenasria avatar Feb 20 '24 13:02 amenasria

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 20 '24 13:02 dd-devflow[bot]