datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Allow for concurrency of macOS GitHub Actions jobs

Open ofek opened this issue 1 year ago • 1 comments

Motivation

Required for https://github.com/DataDog/datadog-agent-macos-build/pull/171

ofek avatar Feb 15 '24 16:02 ofek

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 39c50941-1389-412e-9911-c623d84e0700 Baseline: 0a6ab3428e0fa25b014c02855f19a4e29189f1f3 Comparison: 53b46ca7e5caf48bcd01d82ad4b8ebc2f742a11c Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.70 [-7.26, +5.86]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.87 [-0.55, +2.30]
file_tree memory utilization +0.51 [+0.44, +0.58]
process_agent_standard_check_with_stats memory utilization +0.15 [+0.11, +0.18]
process_agent_standard_check memory utilization +0.02 [-0.02, +0.06]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.02 [-0.06, +0.01]
trace_agent_json ingress throughput -0.04 [-0.09, +0.00]
idle memory utilization -0.13 [-0.16, -0.10]
tcp_syslog_to_blackhole ingress throughput -0.29 [-0.36, -0.22]
otel_to_otel_logs ingress throughput -0.55 [-1.15, +0.05]
file_to_blackhole % cpu utilization -0.70 [-7.26, +5.86]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 15 '24 18:02 pr-commenter[bot]

/merge

amenasria avatar Feb 20 '24 13:02 amenasria

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 20 '24 13:02 dd-devflow[bot]