datadog-agent
datadog-agent copied to clipboard
[CONTINT-3407] Assert tag values in docker e2e tests for dogstatsd
What does this PR do?
Address
- https://github.com/DataDog/datadog-agent/pull/21337/files#r1426462945
- https://github.com/DataDog/datadog-agent/pull/21337/files#r1426463245
Motivation
Make the e2e tests validate as much things as possible.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 1fa7f7c5-0ba8-4b26-902e-19fed7335096 Baseline: aac883cc4f74127aa9e99225898e7b96fc9775f5 Comparison: 47b894970c1f787718e5ab73a9ab2cefe20f1744 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.07 | [-6.65, +6.50] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.15 | [+1.09, +1.21] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.82 | [-0.63, +2.27] |
➖ | idle | memory utilization | +0.12 | [+0.09, +0.14] |
➖ | file_tree | memory utilization | +0.04 | [-0.03, +0.11] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | -0.01 | [-0.06, +0.04] |
➖ | trace_agent_msgpack | ingress throughput | -0.03 | [-0.04, -0.02] |
➖ | file_to_blackhole | % cpu utilization | -0.07 | [-6.65, +6.50] |
➖ | process_agent_standard_check_with_stats | memory utilization | -0.08 | [-0.12, -0.05] |
➖ | process_agent_real_time_mode | memory utilization | -0.13 | [-0.16, -0.10] |
➖ | process_agent_standard_check | memory utilization | -0.13 | [-0.17, -0.09] |
➖ | otel_to_otel_logs | ingress throughput | -0.74 | [-1.35, -0.13] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".