datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

E2E Test for tailing multi_line logs with a custom pattern

Open rayz opened this issue 1 year ago • 1 comments

What does this PR do?

Adds an e2e test for the logs agent to test tailing multi_line logs with a custom pattern

Motivation

This adds more e2e test coverage for multi line logs. (Auto multi line detection was covered in a previous PR)

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

This is the test

rayz avatar Feb 14 '24 20:02 rayz

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: d956dcaa-c47e-40c6-948b-8012684383a7 Baseline: 76b0775ee800e45b30b4c13d898d2737198a1ae1 Comparison: 8846056e48765c0bd703b5817714029e9153fa31 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.20 [-6.75, +6.35]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.41 [-0.03, +2.85]
tcp_syslog_to_blackhole ingress throughput +1.02 [+0.96, +1.07]
process_agent_standard_check memory utilization +0.34 [+0.30, +0.38]
otel_to_otel_logs ingress throughput +0.32 [-0.27, +0.91]
idle memory utilization +0.23 [+0.20, +0.26]
file_tree memory utilization +0.15 [+0.07, +0.23]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.01]
file_to_blackhole % cpu utilization -0.20 [-6.75, +6.35]
process_agent_real_time_mode memory utilization -0.30 [-0.33, -0.28]
process_agent_standard_check_with_stats memory utilization -0.31 [-0.35, -0.28]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 14 '24 22:02 pr-commenter[bot]

/merge

rayz avatar Feb 16 '24 16:02 rayz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 16:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 17:02 dd-devflow[bot]