datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[windows][USM] converge etw consumer

Open derekwbrown opened this issue 1 year ago • 3 comments

What does this PR do?

Converges the USM code to use the more general ETW component, instead of its own standalone implementation.

Motivation

Not having duplicated code.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

There are automated tests.

However, install agent with USM enabled. Generate traffic to IIS site(s). Ensure those appear as services on back-end.

Reviewer's Checklist

  • [x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [x] A release note has been added or the changelog/no-changelog label has been applied.
  • [x] Changed code has automated tests for its functionality.
  • [x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

derekwbrown avatar Feb 13 '24 20:02 derekwbrown

Go Package Import Differences

Baseline: 199d74cb775d8bd3d8cc015e1a522ee760c03e24 Comparison: 7d1ef89e862e828c2ea836d75150e0817fa79362

binaryosarchchange
agentwindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/util/winutil/etw
agentwindows386
+0, -1
-github.com/DataDog/datadog-agent/pkg/util/winutil/etw
system-probewindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/util/winutil/etw

cit-pr-commenter[bot] avatar Feb 14 '24 02:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 054b8ba6-09d4-4759-a1cd-d492b8b16226 Baseline: 199d74cb775d8bd3d8cc015e1a522ee760c03e24 Comparison: 7d1ef89e862e828c2ea836d75150e0817fa79362

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.63 [-7.16, +5.89]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_standard_check_with_stats memory utilization +0.52 [+0.49, +0.56]
trace_agent_msgpack ingress throughput +0.03 [+0.02, +0.04]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api_cpu % cpu utilization -0.01 [-1.41, +1.39]
trace_agent_json ingress throughput -0.02 [-0.04, +0.00]
process_agent_standard_check memory utilization -0.05 [-0.08, -0.02]
idle memory utilization -0.14 [-0.17, -0.10]
otel_to_otel_logs ingress throughput -0.18 [-0.79, +0.44]
process_agent_real_time_mode memory utilization -0.23 [-0.27, -0.19]
file_tree memory utilization -0.59 [-0.66, -0.53]
file_to_blackhole % cpu utilization -0.63 [-7.16, +5.89]
tcp_syslog_to_blackhole ingress throughput -0.82 [-0.88, -0.75]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 14 '24 03:02 pr-commenter[bot]

p.s., you didn't set qa/done tag nor described qa steps in the description

guyarb avatar Feb 15 '24 02:02 guyarb

/merge

derekwbrown avatar Feb 29 '24 04:02 derekwbrown

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 04:02 dd-devflow[bot]