datadog-agent
datadog-agent copied to clipboard
[ASCII-1184] Add IMDSv2 as host alias
What does this PR do?
This PR adds IMDSv2 instance id to the EC2 host alias.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Here are the steps to QA:
-
Create a EC2 instance with metadata version V2 only. It should be either a Windows instance or a non nitro instance (For example use the instance type
t2.xlarge) -
Make sure that host alias is empty when running
agent status
Hostnames
=========
hostname: i-008828bfa8ad51c7c
socket-fqdn: ip-10-0-3-138.ec2.internal.
socket-hostname: i-008828bfa8ad51c7c
hostname provider: os
- Update the Agent to version
7.52.X - Make sure that host alias contains the instance ID when running
agent status. Instance id starts withi-
========
Hostname
========
host_aliases: [i-008828bfa8ad51c7c]
hostname: i-008828bfa8ad51c7c
socket-fqdn: ip-10-0-3-138.ec2.internal.
socket-hostname: i-008828bfa8ad51c7c
hostname provider: os
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [ ] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 625c9e47-aaea-49e0-960f-db0bf77ef758 Baseline: c288bca73c93324c498dd55a23d3734f482328c4 Comparison: 0334140fb77d7f9fa18c5cb99e3acc9bd6c6263e Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.16 | [-6.42, +6.75] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.51 | [-0.11, +1.13] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.19 | [+0.15, +0.23] |
| ➖ | file_to_blackhole | % cpu utilization | +0.16 | [-6.42, +6.75] |
| ➖ | process_agent_standard_check | memory utilization | +0.16 | [+0.11, +0.21] |
| ➖ | trace_agent_json | ingress throughput | +0.04 | [+0.00, +0.07] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.02, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.12 | [-0.17, -0.06] |
| ➖ | idle | memory utilization | -0.17 | [-0.21, -0.14] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.55 | [-0.59, -0.52] |
| ➖ | file_tree | memory utilization | -1.11 | [-1.23, -1.00] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.83 | [-4.22, -1.45] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is next! (estimated merge in less than 49m)
Use /merge -c to cancel this operation!