fix(CI): Add a need condition to force tests to start earlier

[chouetz]

What does this PR do?

Add a needs condition to save time in the overall CI process. Without definition, jobs will wait for completion of all the previous stages, whereas they could nearly all start together.

Motivation

Improve overall CI duration

Additional Notes

I've forced the default new-e2e template with deploy_rpm_testing-a6_x64 and deploy_rpm_testing-a7_x64 as they appear as the last jobs from the kitchen_deploy stage. This is maybe fragile, we might want to put all the jobs of the stage to be sure

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

• [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• [ ] A release note has been added or the changelog/no-changelog label has been applied.
• [ ] Changed code has automated tests for its functionality.
• [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
• [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
• [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• [ ] If applicable, the config template has been updated.

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 6abb6ebb-ae81-478c-90d4-89009f4e96d2 Baseline: 25972295ec1c7c4230a31628d38b3e89bd852a32 Comparison: 51c4802da53321b1002c6a639d7e587386d4f936

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.87	[-5.71, +7.45]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.87	[-5.71, +7.45]
➖	otel_to_otel_logs	ingress throughput	+0.50	[+0.07, +0.94]
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.43	[-4.80, +5.67]
➖	file_tree	memory utilization	+0.25	[+0.19, +0.31]
➖	idle	memory utilization	+0.21	[+0.17, +0.25]
➖	process_agent_standard_check	memory utilization	+0.21	[+0.18, +0.24]
➖	process_agent_standard_check_with_stats	memory utilization	+0.12	[+0.10, +0.14]
➖	basic_py_check	% cpu utilization	+0.08	[-2.40, +2.57]
➖	process_agent_real_time_mode	memory utilization	+0.01	[-0.02, +0.05]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.01]
➖	trace_agent_json	ingress throughput	+0.00	[-0.02, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.37	[-0.47, -0.27]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.87	[-3.75, +2.01]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[chouetz]

I left few comments below but there are also issues in pieces that I couldn’t comment.

For ex., the k8s-e2e-cws-dev job contains an explicit needs: [] statement that will override the needs clause inherited from the .k8s_e2e_template template.

Thanks for your review. As discussed, I updated the PR:

• added correct dependency for k8s-e2e tests, with templates for main and dev parts using variables for more factorization
• Created 2 new-e2e-template-needs-* template to handle needs on kitchen_deploy stage or deploy_containers one

[chouetz]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

[dd-devflow[bot]]

:steam_locomotive: Gitlab pipeline started

Started pipeline #28417537

[chouetz]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!