datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

fix autoconfig_exclude_features / autoconfig_include_features to match the code

Open kangaechu opened this issue 1 year ago • 2 comments
trafficstars

What does this PR do?

Fix autoconfig_exclude_features / autoconfig_include_features parameters to fit the code.

Motivation

There is a difference between the values that can be specified in the code and in the configuration file.

https://github.com/DataDog/datadog-agent/blob/191c12924e3d207ce99cd74932d202ee64c56920/pkg/config/env/environment_container_ features.go

Reviewer's Checklist.

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

kangaechu avatar Feb 13 '24 02:02 kangaechu

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Feb 13 '24 02:02 bits-bot

I couldn't add changelog/no-changelog label, so would someone add this label?

kangaechu avatar Feb 13 '24 02:02 kangaechu

/merge

jeremy-hanna avatar Feb 16 '24 15:02 jeremy-hanna

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 15:02 dd-devflow[bot]