datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[WKINT-383] Add new E2E tests

Open derekwbrown opened this issue 1 year ago • 3 comments

This is a preliminary PR

Attempts to replicate the behavior of copying precompiled test executables to the host, and executing them there.

Includes the ability to set up IIS (a prerequisite for the tests) on windows hosts.

As currently coded, will only work when both the tester and the target are windows hosts. Clearly needs updating to work with linux testers, as that's the target environment.

Implements the tests. Does not actually activate them in CI. Will leave that for a follow-on PR.

Motivation

Migrate tests.

Additional Notes

Describe how to test/QA your changes

PR is entirely tests.

Reviewer's Checklist

  • [x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [x] A release note has been added or the changelog/no-changelog label has been applied.
  • [x] Changed code has automated tests for its functionality.
  • [x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

derekwbrown avatar Feb 12 '24 20:02 derekwbrown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 8d04ea5e-a954-450b-beda-4378f75869e6 Baseline: 8a928218504a6a8b89f05c17ba5093ba78056676 Comparison: d37b8d1048aaf0b9722c6e45d7f068fe3c6c4962 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.10 [-7.63, +5.42]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.47 [+0.44, +0.50]
process_agent_standard_check memory utilization +0.24 [+0.20, +0.27]
process_agent_standard_check_with_stats memory utilization +0.18 [+0.14, +0.21]
tcp_syslog_to_blackhole ingress throughput +0.03 [-0.03, +0.08]
trace_agent_msgpack ingress throughput +0.01 [+0.00, +0.03]
trace_agent_json ingress throughput +0.01 [-0.02, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
process_agent_real_time_mode memory utilization -0.41 [-0.44, -0.38]
file_tree memory utilization -0.56 [-0.63, -0.48]
otel_to_otel_logs ingress throughput -0.81 [-1.42, -0.21]
file_to_blackhole % cpu utilization -1.10 [-7.63, +5.42]
uds_dogstatsd_to_api_cpu % cpu utilization -3.21 [-4.59, -1.82]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 14 '24 08:02 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=37463597 --os-family=ubuntu

Note: This applies to commit 95a9fc37

pr-commenter[bot] avatar Mar 13 '24 22:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: d98678dc-d6c6-47f5-8c15-407734790bfd Metrics dashboard Target profiles

Baseline: fc7a528e13a8c327037ca451da897747e2c9dce0 Comparison: 07b10867500c4b7caeb796db0d6634db55ddf086

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
file_tree memory utilization +1.73 [+1.61, +1.85] Logs
tcp_syslog_to_blackhole ingress throughput +1.28 [-11.66, +14.22] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.75 [-0.14, +1.65] Logs
basic_py_check % cpu utilization +0.48 [-2.16, +3.11] Logs
pycheck_1000_100byte_tags % cpu utilization +0.02 [-4.81, +4.86] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] Logs
otel_to_otel_logs ingress throughput -0.33 [-1.14, +0.48] Logs
idle memory utilization -0.34 [-0.38, -0.31] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 13 '24 23:03 pr-commenter[bot]

Can you please move ownership of these tests to wkit team? You can edit .github/CODEOWNERS file

pducolin avatar May 02 '24 10:05 pducolin

Can you please move ownership of these tests to wkit team? You can edit .github/CODEOWNERS file @pducolin

Anything beyond https://github.com/DataDog/datadog-agent/pull/22793/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R574

derekwbrown avatar May 02 '24 16:05 derekwbrown

[Fast Unit Tests Report]

On pipeline 37463597 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

/merge

derekwbrown avatar Jun 24 '24 23:06 derekwbrown

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jun 24 '24 23:06 dd-devflow[bot]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Jun 24 '24 23:06 dd-devflow[bot]