datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[DRAFT][CWS] one go-routine per event consumer

Open safchain opened this issue 1 year ago • 1 comments

What does this PR do?

This PR start go-routine per event consumer. The global go-routine handles first the event for the event handler and then for each consumer

  • call the copy function
  • push the output of the copy function to a chan
  • the consumer consumes the chan and call the handler

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

safchain avatar Feb 12 '24 14:02 safchain

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 70f1629e-4e5e-4fdd-9ee1-7b56cc09afc7 Baseline: 53ac42512dd76efd555a937d3ba03f54fb43f2ea Comparison: 9a5067c8b698159413d1e344ed879e8a691b1a0b Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.53 [-7.09, +6.03]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +1.39 [-0.01, +2.79]
process_agent_standard_check_with_stats memory utilization +0.24 [+0.21, +0.28]
file_tree memory utilization +0.12 [+0.05, +0.20]
process_agent_standard_check memory utilization +0.05 [+0.01, +0.08]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.04, +0.02]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
tcp_syslog_to_blackhole ingress throughput -0.14 [-0.21, -0.07]
process_agent_real_time_mode memory utilization -0.17 [-0.20, -0.13]
file_to_blackhole % cpu utilization -0.53 [-7.09, +6.03]
idle memory utilization -0.56 [-0.60, -0.53]
otel_to_otel_logs ingress throughput -1.32 [-1.92, -0.72]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 12 '24 17:02 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 86964ad8-d864-4579-9ea5-8bd3adab93eb Baseline: bbfeda2c44251a4368bb8a8cf21548d568f9a1f2 Comparison: 4d768afd01009ce37773062f028f90119a5c7d82

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +5.36 [-16.46, +27.18]
pycheck_1000_100byte_tags % cpu utilization +3.94 [-0.86, +8.73]
basic_py_check % cpu utilization +1.57 [-0.95, +4.10]
file_tree memory utilization +0.52 [+0.43, +0.61]
idle memory utilization +0.34 [+0.31, +0.38]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.01, +0.05]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
otel_to_otel_logs ingress throughput -0.32 [-0.73, +0.09]
uds_dogstatsd_to_api_cpu % cpu utilization -0.40 [-3.28, +2.48]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar May 06 '24 18:05 pr-commenter[bot]

I don't think the import changes reported by https://github.com/DataDog/datadog-agent/pull/22774#issuecomment-2096429369 are acceptable, not sure I understand why those are imported everywhere now on the other hand

paulcacheux avatar May 07 '24 08:05 paulcacheux

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34342912 --os-family=ubuntu

pr-commenter[bot] avatar May 07 '24 11:05 pr-commenter[bot]

Should this be in the open state?

hmahmood avatar May 08 '24 14:05 hmahmood

/merge

safchain avatar May 15 '24 11:05 safchain

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 27m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar May 15 '24 11:05 dd-devflow[bot]