datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS][SEC-12592] decouple security profile event types

Open YoannGh opened this issue 1 year ago • 2 comments

What does this PR do?

This PR decouples the event types used to suppress events from those used to generate drift events by adding a new runtime_security_config.security_profile.auto_suppression.event_types config parameter.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

YoannGh avatar Feb 08 '24 16:02 YoannGh

Go Package Import Differences

Baseline: 760664614225f5f9a49e33ac203cbb096a8fa68f Comparison: c7e23d9d9a217df7192c43481dddde556fdbdbd9

binaryosarchchange
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
security-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
security-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
system-probelinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
system-probelinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression
system-probewindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/rules/autosuppression

cit-pr-commenter[bot] avatar Feb 08 '24 17:02 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 78780c30-de15-4650-909f-25fcedfd54c1 Baseline: 760664614225f5f9a49e33ac203cbb096a8fa68f Comparison: c7e23d9d9a217df7192c43481dddde556fdbdbd9 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.64 [-7.16, +5.88]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.63 [+0.55, +0.70]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.03]
trace_agent_json ingress throughput +0.02 [-0.00, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
tcp_syslog_to_blackhole ingress throughput -0.05 [-0.10, +0.01]
process_agent_standard_check memory utilization -0.14 [-0.18, -0.10]
process_agent_real_time_mode memory utilization -0.22 [-0.27, -0.17]
process_agent_standard_check_with_stats memory utilization -0.28 [-0.32, -0.25]
otel_to_otel_logs ingress throughput -0.33 [-0.97, +0.31]
idle memory utilization -0.41 [-0.44, -0.38]
file_to_blackhole % cpu utilization -0.64 [-7.16, +5.88]
uds_dogstatsd_to_api_cpu % cpu utilization -0.84 [-2.27, +0.59]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 08 '24 18:02 pr-commenter[bot]

/merge

YoannGh avatar Feb 16 '24 13:02 YoannGh

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 13:02 dd-devflow[bot]