datadog-agent
datadog-agent copied to clipboard
[CONS-6006, CONTINT-3700] Fix duplicated logs with K8s jobs
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triage
milestone is set. - [ ] Use the
major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changelog
label has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided. Except if the
qa/skip-qa
label, with required eitherqa/done
orqa/no-code-change
labels, are applied. - [ ] At least one
team/..
label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operator
andneed-change/helm
labels have been applied. - [ ] If applicable, the
k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 27f0d054-5675-4229-b0c2-382d4be8b591 Baseline: d09ec6e5b4161f6048c93bed228df96714512b4d Comparison: da2538c1d9e17c0f530e192537fadccb56780fba Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_tree | memory utilization | +1.12 | [+1.04, +1.19] |
➖ | idle | memory utilization | +0.71 | [+0.68, +0.74] |
➖ | file_to_blackhole | % cpu utilization | +0.25 | [-6.33, +6.82] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_tree | memory utilization | +1.12 | [+1.04, +1.19] |
➖ | idle | memory utilization | +0.71 | [+0.68, +0.74] |
➖ | process_agent_standard_check | memory utilization | +0.31 | [+0.26, +0.35] |
➖ | file_to_blackhole | % cpu utilization | +0.25 | [-6.33, +6.82] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.11 | [+0.07, +0.15] |
➖ | process_agent_real_time_mode | memory utilization | +0.11 | [+0.06, +0.16] |
➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.02, +0.05] |
➖ | trace_agent_json | ingress throughput | +0.02 | [-0.00, +0.05] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.04, +0.04] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.06, +0.06] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.19 | [-0.28, -0.11] |
➖ | otel_to_otel_logs | ingress throughput | -2.20 | [-2.88, -1.51] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -3.21 | [-4.60, -1.83] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector
Regression Detector Results
Run ID: ea3472f6-ba94-4395-ada0-8ba309d13bac Metrics dashboard Target profiles
Baseline: 6970ab2e6a5a9f26908da8b1ff47805e5888fa34 Comparison: 9101996daedaee41a949b2c1578f24182202f4a2
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.34 | [-1.32, +4.01] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.38 | [-12.60, +13.37] | Logs |
➖ | idle | memory utilization | +0.15 | [+0.11, +0.18] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | file_tree | memory utilization | -0.35 | [-0.39, -0.31] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.54 | [-1.34, +0.27] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.69 | [-1.56, +0.19] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.80 | [-5.67, +4.08] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=37322952 --os-family=ubuntu
Note: This applies to commit 9101996d
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main
is 26m.
Use /merge -c
to cancel this operation!