datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CONTINT-3755] Bump buildkit version

Open AliDatadog opened this issue 1 year ago • 13 comments

What does this PR do?

This PR bumps the version of buildkit to fix a non applicable CVE. It is imported by Trivy.

Motivation

Clean vuln reports.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The scope of the changes are very large. Feel free to recommend anything more.

New E2E tests should cover the container checks and container tags.

We should test that docker events are still emitted with the proper fields. Install the agent in a dockerized environment, run docker containers and check that metrics and events are still sent.

Run the SBOM collection in a dockerized environment.

Test result notebook.

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

AliDatadog avatar Feb 07 '24 15:02 AliDatadog

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Feb 07 '24 15:02 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #27885212

dd-devflow[bot] avatar Feb 07 '24 15:02 dd-devflow[bot]

Go Package Import Differences

Baseline: 3bf100a143615a070fa5376db1a01b40f6410209 Comparison: e57492edc7a982418f59f6cc4cdb8dd8a95b6a65

binaryosarchchange
agentlinuxamd64
+9, -3
+github.com/aws/aws-sdk-go-v2/internal/context
+github.com/aws/smithy-go/container/private/cache
+github.com/aws/smithy-go/container/private/cache/lru
+github.com/aws/smithy-go/private/requestcompression
-github.com/containerd/typeurl
+github.com/distribution/reference
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
agentlinuxarm64
+9, -3
+github.com/aws/aws-sdk-go-v2/internal/context
+github.com/aws/smithy-go/container/private/cache
+github.com/aws/smithy-go/container/private/cache/lru
+github.com/aws/smithy-go/private/requestcompression
-github.com/containerd/typeurl
+github.com/distribution/reference
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
agentwindowsamd64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
cluster-agentlinuxamd64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
cluster-agentlinuxarm64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
dogstatsdlinuxamd64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
dogstatsdlinuxarm64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
process-agentlinuxamd64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
process-agentlinuxarm64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
process-agentwindowsamd64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
security-agentlinuxamd64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
security-agentlinuxarm64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
serverlesslinuxamd64
+1, -0
+github.com/aws/smithy-go/private/requestcompression
serverlesslinuxarm64
+1, -0
+github.com/aws/smithy-go/private/requestcompression
system-probelinuxamd64
+9, -3
+github.com/aws/aws-sdk-go-v2/internal/context
+github.com/aws/smithy-go/container/private/cache
+github.com/aws/smithy-go/container/private/cache/lru
+github.com/aws/smithy-go/private/requestcompression
-github.com/containerd/typeurl
+github.com/distribution/reference
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
system-probelinuxarm64
+9, -3
+github.com/aws/aws-sdk-go-v2/internal/context
+github.com/aws/smithy-go/container/private/cache
+github.com/aws/smithy-go/container/private/cache/lru
+github.com/aws/smithy-go/private/requestcompression
-github.com/containerd/typeurl
+github.com/distribution/reference
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
system-probewindowsamd64
+5, -2
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
trace-agentlinuxamd64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
trace-agentlinuxarm64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy
trace-agentwindowsamd64
+5, -4
-github.com/docker/distribution/digestset
-github.com/docker/distribution/reference
+github.com/distribution/reference
+github.com/docker/docker/api/types/checkpoint
+github.com/docker/docker/api/types/system
+github.com/docker/docker/image/spec/specs-go/v1
+github.com/docker/docker/internal/multierror
-golang.org/x/net/internal/socks
-golang.org/x/net/proxy

cit-pr-commenter[bot] avatar Feb 07 '24 15:02 cit-pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Feb 07 '24 16:02 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #27892955

dd-devflow[bot] avatar Feb 07 '24 16:02 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Feb 08 '24 15:02 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #27970204

dd-devflow[bot] avatar Feb 08 '24 15:02 dd-devflow[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a9ed542c-795e-4ec1-b1f6-5c430cc36f93 Baseline: 3bf100a143615a070fa5376db1a01b40f6410209 Comparison: e57492edc7a982418f59f6cc4cdb8dd8a95b6a65 Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.04 [-7.57, +5.48]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_standard_check memory utilization +1.11 [+1.07, +1.14]
file_tree memory utilization +0.97 [+0.89, +1.04]
process_agent_standard_check_with_stats memory utilization +0.69 [+0.66, +0.73]
idle memory utilization +0.31 [+0.28, +0.34]
process_agent_real_time_mode memory utilization +0.22 [+0.19, +0.25]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.00 [-0.03, +0.03]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.00]
tcp_syslog_to_blackhole ingress throughput -0.20 [-0.26, -0.14]
otel_to_otel_logs ingress throughput -0.58 [-1.22, +0.06]
uds_dogstatsd_to_api_cpu % cpu utilization -0.61 [-2.04, +0.81]
file_to_blackhole % cpu utilization -1.04 [-7.57, +5.48]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Feb 09 '24 13:02 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

AliDatadog avatar Feb 09 '24 15:02 AliDatadog

:steam_locomotive: Gitlab pipeline started

Started pipeline #28041621

dd-devflow[bot] avatar Feb 09 '24 15:02 dd-devflow[bot]

/merge

AliDatadog avatar Feb 15 '24 10:02 AliDatadog

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 15 '24 10:02 dd-devflow[bot]

:warning: MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Feb 15 '24 14:02 dd-devflow[bot]

/merge

AliDatadog avatar Feb 16 '24 15:02 AliDatadog

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 4 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 16 '24 15:02 dd-devflow[bot]