datadog-agent
datadog-agent copied to clipboard
[PROCS-3728] Modify process check to populate process with the process context
What does this PR do?
This PR modifies the process check to populate process with the newly created field "ProcessContext", which has been added to agent-payload in the following PR.
Motivation
Process level data such as Process-context needs to be integrated into the process check, as outlined in the following JIRA ticket: https://datadoghq.atlassian.net/browse/PROCS-3728
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Using the standard config, run the following steps:
- Run the Process check
- Verify that processes contain the
ProcessContextattribute - Verify that
ProcessContextlooks something like this:ProcessContext: ["process_context:sh"]
Reviewer's Checklist
- [x] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [x] A release note has been added or the
changelog/no-changeloglabel has been applied. - [x] Changed code has automated tests for its functionality.
- [x] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [x] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: c6812ecd-c275-4da5-bc47-f7fe8e44e0fb Baseline: 091536ce2affeb146584d17a319ab9a5103c7ea9 Comparison: 0edaf84c8680b913a9faa3d94c95bef61fdf2b63 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +0.48 | [-6.13, +7.08] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +0.77 | [+0.15, +1.39] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.72 | [-0.72, +2.15] |
| ➖ | file_to_blackhole | % cpu utilization | +0.48 | [-6.13, +7.08] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.32 | [+0.27, +0.38] |
| ➖ | file_tree | memory utilization | +0.15 | [+0.07, +0.23] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.01, +0.05] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.03 | [-0.01, +0.07] |
| ➖ | process_agent_standard_check | memory utilization | +0.00 | [-0.04, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
| ➖ | idle | memory utilization | -0.17 | [-0.19, -0.14] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.71 | [-0.74, -0.68] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 8 builds ahead! (estimated merge in less than 2h)
Use /merge -c to cancel this operation!