datadog-agent
datadog-agent copied to clipboard
Generate SBOM on Windows with OS info and KBs
What does this PR do?
Collects KB and system info on Windows and send it in a SBOM
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [ ] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Go Package Import Differences
Baseline: d9ff65e15240ec2416d945a9df67ea33049ef73c Comparison: 4499569d4fa00685ab7aa5cca6bdfc2cb8c73343
| binary | os | arch | change |
|---|---|---|---|
| agent | windows | amd64 | +2, -0
+github.com/DataDog/datadog-agent/pkg/sbom/collectors/host
+github.com/DataDog/gopsutil/host
|
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 44.95%. Comparing base (
d9ff65e) to head (4499569). Report is 234 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #22564 +/- ##
==========================================
- Coverage 44.96% 44.95% -0.02%
==========================================
Files 2328 2328
Lines 268349 268349
==========================================
- Hits 120654 120627 -27
- Misses 138104 138129 +25
- Partials 9591 9593 +2
| Flag | Coverage Δ | |
|---|---|---|
| amzn_aarch64 | 45.77% <ø> (-0.01%) |
:arrow_down: |
| centos_x86_64 | 45.68% <ø> (-0.02%) |
:arrow_down: |
| ubuntu_aarch64 | 45.77% <ø> (-0.02%) |
:arrow_down: |
| ubuntu_x86_64 | 45.77% <ø> (-0.02%) |
:arrow_down: |
| windows_amd64 | 50.99% <ø> (-0.23%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=35619585 --os-family=ubuntu
Regression Detector
Regression Detector Results
Run ID: bc171f67-de4b-4525-aaf6-4cb51b799ec3 Baseline: 55cf7d8df6921c0e7521453a3dafb75487cad7aa Comparison: 4499569d4fa00685ab7aa5cca6bdfc2cb8c73343
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +12.67 | [-9.53, +34.88] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.43 | [-1.42, +4.28] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +1.34 | [-3.37, +6.06] |
| ➖ | idle | memory utilization | +0.59 | [+0.55, +0.63] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.15 | [-0.22, +0.52] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.02] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
| ➖ | trace_agent_json | ingress throughput | -0.01 | [-0.06, +0.03] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.06, +0.02] |
| ➖ | file_tree | memory utilization | -0.09 | [-0.21, +0.03] |
| ➖ | basic_py_check | % cpu utilization | -0.42 | [-2.93, +2.10] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
This build is going to start soon! (estimated merge in less than 27m)
Use /merge -c to cancel this operation!