[experiment] Remove remote configuration from serverless agent

Open GustavoCaso opened this issue 6 months ago • 3 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Jan 31 '24 12:01 GustavoCaso

Go Package Import Differences

Baseline: f0e5f932ecda5207391ca3770a178d3308f42621 Comparison: 61e465098130c75ef202d2ba102a5a182406fae2

binary	os	arch	change
agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	windows	386	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	darwin	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
agent	darwin	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
iot-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
iot-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent-cloudfoundry	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
cluster-agent-cloudfoundry	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
dogstatsd	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
dogstatsd	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	darwin	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
process-agent	darwin	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-process-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
security-agent	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
security-agent	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
serverless	linux	amd64	+0, -39 -github.com/DataDog/datadog-agent/pkg/config/remote/client -github.com/DataDog/datadog-agent/pkg/config/remote/meta -github.com/DataDog/datadog-agent/pkg/remoteconfig/state -github.com/DataDog/datadog-agent/pkg/remoteconfig/state/products/apmsampling -github.com/DataDog/datadog-agent/pkg/trace/remoteconfighandler -github.com/DataDog/go-tuf/client -github.com/DataDog/go-tuf/data -github.com/DataDog/go-tuf/internal/roles -github.com/DataDog/go-tuf/internal/sets -github.com/DataDog/go-tuf/pkg/keys -github.com/DataDog/go-tuf/pkg/targets -github.com/DataDog/go-tuf/util -github.com/DataDog/go-tuf/verify -github.com/secure-systems-lab/go-securesystemslib/cjson -golang.org/x/xerrors -golang.org/x/xerrors/internal -gopkg.in/DataDog/dd-trace-go.v1/datastreams/options -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/internal -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer -gopkg.in/DataDog/dd-trace-go.v1/internal -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/datastreams -gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/azure -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/cachedfetch -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/ec2 -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/ecs -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/gce -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/httputils -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/validate -gopkg.in/DataDog/dd-trace-go.v1/internal/namingschema -gopkg.in/DataDog/dd-trace-go.v1/internal/normalizer -gopkg.in/DataDog/dd-trace-go.v1/internal/osinfo -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig -gopkg.in/DataDog/dd-trace-go.v1/internal/samplernames -gopkg.in/DataDog/dd-trace-go.v1/internal/telemetry -gopkg.in/DataDog/dd-trace-go.v1/internal/traceprof
serverless	linux	arm64	+0, -43 -github.com/DataDog/datadog-agent/pkg/config/remote/client -github.com/DataDog/datadog-agent/pkg/config/remote/meta -github.com/DataDog/datadog-agent/pkg/remoteconfig/state -github.com/DataDog/datadog-agent/pkg/remoteconfig/state/products/apmsampling -github.com/DataDog/datadog-agent/pkg/trace/remoteconfighandler -github.com/DataDog/go-libddwaf/v2/internal/lib -github.com/DataDog/go-tuf/client -github.com/DataDog/go-tuf/data -github.com/DataDog/go-tuf/internal/roles -github.com/DataDog/go-tuf/internal/sets -github.com/DataDog/go-tuf/pkg/keys -github.com/DataDog/go-tuf/pkg/targets -github.com/DataDog/go-tuf/util -github.com/DataDog/go-tuf/verify -github.com/ebitengine/purego -github.com/ebitengine/purego/internal/fakecgo -github.com/ebitengine/purego/internal/strings -github.com/secure-systems-lab/go-securesystemslib/cjson -golang.org/x/xerrors -golang.org/x/xerrors/internal -gopkg.in/DataDog/dd-trace-go.v1/datastreams/options -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/internal -gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer -gopkg.in/DataDog/dd-trace-go.v1/internal -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/datastreams -gopkg.in/DataDog/dd-trace-go.v1/internal/globalconfig -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/azure -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/cachedfetch -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/ec2 -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/ecs -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/gce -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/httputils -gopkg.in/DataDog/dd-trace-go.v1/internal/hostname/validate -gopkg.in/DataDog/dd-trace-go.v1/internal/namingschema -gopkg.in/DataDog/dd-trace-go.v1/internal/normalizer -gopkg.in/DataDog/dd-trace-go.v1/internal/osinfo -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig -gopkg.in/DataDog/dd-trace-go.v1/internal/samplernames -gopkg.in/DataDog/dd-trace-go.v1/internal/telemetry -gopkg.in/DataDog/dd-trace-go.v1/internal/traceprof
system-probe	linux	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
system-probe	linux	arm64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
system-probe	windows	amd64	+0, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	linux	amd64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	linux	arm64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	windows	amd64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	windows	386	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	darwin	amd64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
trace-agent	darwin	arm64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig
heroku-trace-agent	linux	amd64	+1, -4 -github.com/DataDog/appsec-internal-go/appsec -github.com/DataDog/appsec-internal-go/log +github.com/DataDog/datadog-agent/pkg/config/remote/data -gopkg.in/DataDog/dd-trace-go.v1/internal/appsec -gopkg.in/DataDog/dd-trace-go.v1/internal/remoteconfig

Jan 31 '24 12:01 cit-pr-commenter[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: b1e7ba19-ee8f-416f-b267-3fc11120ea22 Baseline: 82382e2cc2e4a53d55a25f6907afdd5c3f158ced Comparison: c761233e365bcbfb8ab90dc2d8e998e61ccb1531 Total CPUs: 7

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	idle	memory utilization	+0.16	[+0.14, +0.18]
➖	file_tree	memory utilization	-0.01	[-0.08, +0.06]
➖	file_to_blackhole	% cpu utilization	-0.87	[-7.40, +5.66]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+0.16	[+0.10, +0.22]
➖	idle	memory utilization	+0.16	[+0.14, +0.18]
➖	trace_agent_msgpack	ingress throughput	+0.03	[+0.01, +0.05]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.06, +0.06]
➖	trace_agent_json	ingress throughput	+0.00	[-0.03, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.03, +0.03]
➖	file_tree	memory utilization	-0.01	[-0.08, +0.06]
➖	process_agent_standard_check	memory utilization	-0.23	[-0.27, -0.18]
➖	process_agent_standard_check_with_stats	memory utilization	-0.37	[-0.41, -0.33]
➖	process_agent_real_time_mode	memory utilization	-0.56	[-0.60, -0.53]
➖	otel_to_otel_logs	ingress throughput	-0.68	[-1.39, +0.04]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.80	[-2.23, +0.62]
➖	file_to_blackhole	% cpu utilization	-0.87	[-7.40, +5.66]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Jan 31 '24 13:01 pr-commenter[bot]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between f0e5f932ecda5207391ca3770a178d3308f42621 and 588fb4e37197eb3a28f3c1fab4bd543e751b2fa2.

tl;dr

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │    previous     │
                                      │     sec/op      │
api-gateway-appsec.json                 88.36µ ±     5%
api-gateway-kong-appsec.json            66.96µ ±     2%
api-gateway-kong.json                   65.26µ ±     1%
api-gateway-non-proxy-async.json        100.0µ ±     1%
api-gateway-non-proxy.json              100.2µ ±     1%
api-gateway-websocket-connect.json      67.16µ ±     2%
api-gateway-websocket-default.json      59.37µ ±     2%
api-gateway-websocket-disconnect.json   58.11µ ±     1%
api-gateway.json                        115.9µ ±     8%
application-load-balancer.json          63.03µ ±     7%
cloudfront.json                         51.34µ ±     4%
cloudwatch-events.json                  41.02µ ±     8%
cloudwatch-logs.json                    57.08µ ±    21%
custom.json                             33.31µ ±     7%
dynamodb.json                           102.6µ ±    14%
empty.json                              35.23µ ±     5%
eventbridge-custom.json                 50.75µ ±    12%
http-api.json                           76.58µ ±    18%
kinesis-batch.json                      88.90µ ±     8%
kinesis.json                            67.99µ ±    17%
s3.json                                 81.52µ ±    11%
sns-batch.json                          130.8µ ± 98408%
geomean                                 68.43µ

                                      │   previous    │
                                      │     B/op      │
api-gateway-appsec.json                 41.12Ki ±  3%
api-gateway-kong-appsec.json            28.06Ki ± 11%
api-gateway-kong.json                   25.41Ki ±  0%
api-gateway-non-proxy-async.json        51.66Ki ±  0%
api-gateway-non-proxy.json              50.21Ki ±  0%
api-gateway-websocket-connect.json      27.07Ki ±  0%
api-gateway-websocket-default.json      22.34Ki ±  0%
api-gateway-websocket-disconnect.json   21.97Ki ±  0%
api-gateway.json                        52.94Ki ±  0%
application-load-balancer.json          24.02Ki ±  0%
cloudfront.json                         18.56Ki ±  0%
cloudwatch-events.json                  11.60Ki ±  0%
cloudwatch-logs.json                    53.11Ki ±  0%
custom.json                             9.342Ki ±  0%
dynamodb.json                           43.34Ki ±  0%
empty.json                              8.835Ki ±  0%
eventbridge-custom.json                 13.33Ki ±  0%
http-api.json                           24.27Ki ±  0%
kinesis-batch.json                      28.52Ki ±  0%
kinesis.json                            18.27Ki ±  0%
s3.json                                 21.00Ki ±  0%
sns-batch.json                          41.66Ki ± 23%
geomean                                 25.35Ki

                                      │  previous   │
                                      │  allocs/op  │
api-gateway-appsec.json                 629.0 ±  0%
api-gateway-kong-appsec.json            487.0 ±  0%
api-gateway-kong.json                   465.0 ±  0%
api-gateway-non-proxy-async.json        723.0 ±  0%
api-gateway-non-proxy.json              713.0 ±  0%
api-gateway-websocket-connect.json      451.0 ±  0%
api-gateway-websocket-default.json      376.0 ±  0%
api-gateway-websocket-disconnect.json   366.0 ±  0%
api-gateway.json                        785.0 ±  0%
application-load-balancer.json          349.0 ±  0%
cloudfront.json                         280.0 ±  0%
cloudwatch-events.json                  217.0 ±  0%
cloudwatch-logs.json                    210.0 ±  0%
custom.json                             165.0 ±  0%
dynamodb.json                           581.0 ±  0%
empty.json                              156.0 ±  0%
eventbridge-custom.json                 249.0 ±  0%
http-api.json                           424.0 ±  0%
kinesis-batch.json                      382.0 ±  0%
kinesis.json                            278.0 ±  0%
s3.json                                 350.0 ±  0%
sns-batch.json                          443.0 ± 53%
geomean                                 374.5

Feb 20 '24 16:02 github-actions[bot]

datadog-agent datadog-agent copied to clipboard

[experiment] Remove remote configuration from serverless agent

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Go Package Import Differences

Bloop Bleep... Dogbot Here

Regression Detector Results

No significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Serverless Benchmark Results

datadog-agent
datadog-agent copied to clipboard