datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[EBPF-292] Fixes for CWS tests in KMT

Open gjulianm opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

Minor fixes to adapt CWS tests to run in the KMT environment.

  • Specify working directory when executing scripts, as tests might be running in a read-only directory.

Motivation

Additional Notes

See #22336

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

CI tests

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

gjulianm avatar Jan 25 '24 16:01 gjulianm

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 232d8381-0a90-419d-9873-64d9383c4808 Baseline: 7e1916dea3dd943900ebe80b1d2c60b65f4943aa Comparison: 3f8dc0a8020b4ef9b6c3e079e925b614f86bad2b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.26 [-6.30, +6.82]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
process_agent_real_time_mode memory utilization +0.63 [+0.59, +0.67]
file_tree memory utilization +0.54 [+0.47, +0.62]
idle memory utilization +0.30 [+0.26, +0.35]
file_to_blackhole % cpu utilization +0.26 [-6.30, +6.82]
trace_agent_json ingress throughput +0.00 [-0.02, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
process_agent_standard_check_with_stats memory utilization -0.06 [-0.09, -0.02]
process_agent_standard_check memory utilization -0.23 [-0.27, -0.19]
otel_to_otel_logs ingress throughput -0.23 [-0.88, +0.42]
tcp_syslog_to_blackhole ingress throughput -0.53 [-0.59, -0.47]
uds_dogstatsd_to_api_cpu % cpu utilization -1.77 [-3.18, -0.36]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jan 25 '24 17:01 pr-commenter[bot]

Have you seen https://github.com/DataDog/datadog-agent/pull/23277 ? I feel like it solves the same issue no ?

paulcacheux avatar Mar 05 '24 12:03 paulcacheux

Have you seen #23277 ? I feel like it solves the same issue no ?

It's similar but I think that PR doesn't fix the issue completely, I feel like part of the problem is the use of os.TempDir instead of /tmp/ too. For example in this job the TestProcessInterpreter test fails still in KMT.

gjulianm avatar Mar 05 '24 12:03 gjulianm

/merge

gjulianm avatar Mar 05 '24 12:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 30m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 05 '24 12:03 dd-devflow[bot]