datadog-agent
datadog-agent copied to clipboard
unify http plaintext tls tests
What does this PR do?
Runs most of the HTTP tests for plaintext and TLS
Motivation
Expand the coverage of tests for go-tls
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [x] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [x] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [x] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [x] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 4f63dd0b-80a4-4980-bafc-417f640290ec Baseline: d0d0ae95a284532d7e42d186f88742fbf1699989 Comparison: 7ab5a5aebdc267b856aed97294e57325273479c1 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | -0.16 | [-0.19, -0.13] |
| ➖ | file_tree | memory utilization | -0.17 | [-0.23, -0.10] |
| ➖ | file_to_blackhole | % cpu utilization | -0.25 | [-6.83, +6.33] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +2.30 | [+1.53, +3.07] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.11 | [+0.07, +0.15] |
| ➖ | trace_agent_json | ingress throughput | +0.03 | [-0.00, +0.07] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.05, +0.05] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.03, +0.03] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.04 | [-0.07, -0.01] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.08 | [-0.11, -0.05] |
| ➖ | process_agent_standard_check | memory utilization | -0.11 | [-0.15, -0.06] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.14 | [-0.23, -0.06] |
| ➖ | idle | memory utilization | -0.16 | [-0.19, -0.13] |
| ➖ | file_tree | memory utilization | -0.17 | [-0.23, -0.10] |
| ➖ | file_to_blackhole | % cpu utilization | -0.25 | [-6.83, +6.33] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.34 | [-1.78, +1.10] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
/remove
:steam_locomotive: Devflow: /remove
:warning: MergeQueue
This merge request was unqueued
If you need support, contact us on Slack #ci-interfaces!
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 5 builds ahead! (estimated merge in less than 1h)
Use /merge -c to cancel this operation!
/remove
:steam_locomotive: Devflow: /remove
:warning: MergeQueue
This merge request was unqueued
If you need support, contact us on Slack #ci-interfaces!