datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[EBPF-292] Add support for CWS tests on KMT

Open gjulianm opened this issue 1 year ago • 17 comments
trafficstars

What does this PR do?

This PR adds support for CWS tests in the new Kernel Matrix Testing framework

Motivation

Include CWS tests in the KMT framework, so that the team can start working on those tests and getting everything to pass.

Additional Notes

Compared to existing kitchen tests, these are the changes in supported kernels:

Removed:

  • Amazon 5.15
  • Amazon 4.14

Removed, although the jobs were marked as manual in kitchen tests:

  • Centos 7.7
  • RHEL 8.5, 9.1
  • SLES 12, 15
  • OpenSUSE 15.3
  • Oracle 7.9
  • Rocky Linux 9.2

Added:

  • All ARM architectures except for Ubuntu 20, 22 which were already being tested
  • Debian 12
  • Fedora 37, 38

Some tests require minor fixes to pass in the KMT environment. These will be added in a different PR.

While I've tried to share as much of the CI code as possible, there are some things that need to be separate because of different behaviors. A future PR could address these differences and allow sharing all the CI code.

The agent-security team is added as a codeowner in the security_agent.yml file.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The changes are CI tests themselves

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

gjulianm avatar Jan 25 '24 09:01 gjulianm

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 29b411a6-bcb6-4ef7-992a-62c118a98949 Baseline: 1bcb8b5016c93d703093ee2c4994aed9e867b3be Comparison: c05b68662be6f44d35a39a37c8061b74075ff6e1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.30 [-6.27, +6.87]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.30 [-6.27, +6.87]
process_agent_standard_check memory utilization +0.28 [+0.23, +0.33]
idle memory utilization +0.12 [+0.08, +0.15]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.02]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput +0.00 [-0.04, +0.04]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00]
file_tree memory utilization -0.11 [-0.22, -0.00]
process_agent_standard_check_with_stats memory utilization -0.21 [-0.24, -0.17]
process_agent_real_time_mode memory utilization -0.40 [-0.45, -0.35]
otel_to_otel_logs ingress throughput -0.43 [-1.08, +0.22]
tcp_syslog_to_blackhole ingress throughput -0.45 [-0.50, -0.39]
uds_dogstatsd_to_api_cpu % cpu utilization -1.91 [-3.35, -0.47]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jan 25 '24 10:01 pr-commenter[bot]

I think we need a PR in test-infra-definitions to not change the docker root, and mount the docker disk for security agent related tests.

I was seeing the test-infra-definitions code, I think if it doesn't find a disk with that mountpoint it doesn't change the root right? (I'm looking at this code, not sure if there's another place)

gjulianm avatar Jan 29 '24 14:01 gjulianm

I think we need a PR in test-infra-definitions to not change the docker root, and mount the docker disk for security agent related tests.

I was seeing the test-infra-definitions code, I think if it doesn't find a disk with that mountpoint it doesn't change the root right? (I'm looking at this code, not sure if there's another place)

Ah yes, you're right.

usamasaqib avatar Jan 29 '24 16:01 usamasaqib

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true

gjulianm avatar Jan 31 '24 22:01 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #27508070

dd-devflow[bot] avatar Jan 31 '24 22:01 dd-devflow[bot]

/merge

usamasaqib avatar Feb 26 '24 09:02 usamasaqib

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 09:02 dd-devflow[bot]

:x: MergeQueue

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 09:02 dd-devflow[bot]

/merge

usamasaqib avatar Feb 26 '24 11:02 usamasaqib

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 11:02 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 9 builds ahead of this PR! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 26 '24 11:02 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 26 '24 13:02 dd-devflow[bot]

/merge

usamasaqib avatar Feb 29 '24 12:02 usamasaqib

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Feb 29 '24 12:02 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Feb 29 '24 12:02 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

usamasaqib avatar Feb 29 '24 12:02 usamasaqib

:steam_locomotive: Gitlab pipeline started

Started pipeline #29195405

dd-devflow[bot] avatar Feb 29 '24 12:02 dd-devflow[bot]

/merge

gjulianm avatar Mar 01 '24 14:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

/merge

gjulianm avatar Mar 01 '24 14:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 50m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

/merge

gjulianm avatar Mar 01 '24 14:03 gjulianm

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 5 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

:x: MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

/merge

gjulianm avatar Mar 01 '24 14:03 gjulianm

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 14:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 01 '24 15:03 dd-devflow[bot]

:rotating_light: MergeQueue

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

If you need support, contact us on Slack #ci-interfaces with those details!

dd-devflow[bot] avatar Mar 01 '24 15:03 dd-devflow[bot]