datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

add some logging to potential olreader failure cases

Open derekwbrown opened this issue 1 year ago • 1 comments
trafficstars

What does this PR do?

Add s some additional debug logging

Motivation

Some additional troubleshooting help in dev

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Turn on debug logging. look for new logs

Reviewer's Checklist

  • [x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [x] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ x At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

derekwbrown avatar Jan 23 '24 17:01 derekwbrown

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a6c32cd9-1b98-4463-a4d5-d0af1cc8e884 Baseline: 7a608964129d650df437ac8f5726bc7fd0102109 Comparison: e4f0e32cc5cba1e3b32bc6efee9046f840c1341d Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.08 [+0.05, +0.10]
file_to_blackhole % cpu utilization -0.74 [-7.28, +5.80]
file_tree memory utilization -0.76 [-0.82, -0.69]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.53 [-0.91, +1.98]
process_agent_real_time_mode memory utilization +0.51 [+0.49, +0.54]
process_agent_standard_check_with_stats memory utilization +0.48 [+0.44, +0.52]
idle memory utilization +0.08 [+0.05, +0.10]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.03, +0.03]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.05]
trace_agent_json ingress throughput -0.00 [-0.03, +0.03]
process_agent_standard_check memory utilization -0.08 [-0.13, -0.04]
file_to_blackhole % cpu utilization -0.74 [-7.28, +5.80]
file_tree memory utilization -0.76 [-0.82, -0.69]
tcp_syslog_to_blackhole ingress throughput -0.88 [-0.94, -0.82]
otel_to_otel_logs ingress throughput -2.26 [-3.00, -1.52]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jan 23 '24 19:01 pr-commenter[bot]

Hey @derekwbrown What should we do with this one ?

lebauce avatar Jun 13 '24 15:06 lebauce