datadog-agent
datadog-agent copied to clipboard
[EBPF-384]: Encapsulate ebpfTelemetry struct
What does this PR do?
make eBPFTelemetry struct internal singleton in the ebpf/telemetry pkg as it is already being used today to collect telemetry for all ebpf programs
Motivation
code cleanup: avoid propagation of ebpfTelemetry pointer from tracer to all ebpf programs and helper methods.
Additional Notes
next PR will decouple the ebpfErrorsCollector from tracer by moving it to the system-probe cmd along with other global collectors
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [ ] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: b2c59cbc-cbbd-457b-a4df-da32ec4c66bc Baseline: 165e0b373dc4e21f14739c49b81fa34fbb49800b Comparison: 8dc50d9337ef89b9d276af2cd53987931e2bd8b5 Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | -0.33 | [-0.38, -0.29] |
| ➖ | file_to_blackhole | % cpu utilization | -0.86 | [-7.40, +5.69] |
| ➖ | file_tree | memory utilization | -1.26 | [-1.35, -1.18] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +3.36 | [+2.58, +4.14] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.26 | [+0.21, +0.32] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.06 | [+0.01, +0.10] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.02, +0.05] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.05, +0.05] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.03, +0.03] |
| ➖ | process_agent_standard_check | memory utilization | -0.02 | [-0.09, +0.04] |
| ➖ | trace_agent_json | ingress throughput | -0.05 | [-0.08, -0.02] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.31 | [-0.37, -0.26] |
| ➖ | idle | memory utilization | -0.33 | [-0.38, -0.29] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.48 | [-1.92, +0.96] |
| ➖ | file_to_blackhole | % cpu utilization | -0.86 | [-7.40, +5.69] |
| ➖ | file_tree | memory utilization | -1.26 | [-1.35, -1.18] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Closing this PR in favor of ErrorsTelemetryModifier PR