datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

feat(CI): Direct junit upload using standalone ci-uploader

Open chouetz opened this issue 1 year ago • 15 comments

What does this PR do?

Remove the *_junit_upload stages and upload junit files alongside the test jobs using the standalone ci-uploader

Motivation

Simplification of the CI jobs

Additional Notes

Linked PR

  • https://github.com/DataDog/datadog-agent-buildimages/pull/517

Possible Drawbacks / Trade-offs

Standalone binary is in beta release

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

chouetz avatar Jan 17 '24 18:01 chouetz

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true

chouetz avatar Jan 17 '24 18:01 chouetz

:rotating_light: Devflow

POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/datadog-agent/pipeline: 400 {message: {base: [Local file .gitlab/docker_common/publish_job_templates.yml does not exist!]}}

Details

child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: bd457230-b185-46c4-a81f-62419d785b59_33, runID: f44c689d-d85b-49fd-9153-ab91dc6392f2, initiatedEventID: 33, startedEventID: 34): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: f44c689d-d85b-49fd-9153-ab91dc6392f2_14, runID: a83c32e2-375a-45b8-a372-b3c475da3758, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 8, startedEventID: 9, identity: 1@gitlab-worker-ff4465bb5-kqzfx@): POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/datadog-agent/pipeline: 400 {message: {base: [Local file `.gitlab/docker_common/publish_job_templates.yml` does not exist!]}} (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Jan 17 '24 18:01 dd-devflow[bot]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 3ba8b6f5-8a52-414c-ac70-c1bc3e6ebfeb Baseline: af00e79336597e0723c1e20dfe6eaf25a4e13e78 Comparison: 3d5037fd897746f8c11ec5d7c509f9cd308fbf08

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.00 [-6.56, +6.56]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.38 [-1.04, +1.80]
process_agent_real_time_mode memory utilization +0.22 [+0.16, +0.28]
tcp_syslog_to_blackhole ingress throughput +0.16 [+0.10, +0.22]
process_agent_standard_check memory utilization +0.15 [+0.12, +0.19]
process_agent_standard_check_with_stats memory utilization +0.14 [+0.10, +0.18]
file_to_blackhole % cpu utilization +0.00 [-6.56, +6.56]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.03 [-0.06, +0.01]
trace_agent_msgpack ingress throughput -0.03 [-0.04, -0.02]
otel_to_otel_logs ingress throughput -0.22 [-0.89, +0.45]
idle memory utilization -0.42 [-0.47, -0.37]
basic_py_check % cpu utilization -0.74 [-2.90, +1.42]
file_tree memory utilization -1.18 [-1.29, -1.07]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Jan 18 '24 11:01 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

chouetz avatar Feb 16 '24 15:02 chouetz

:steam_locomotive: Gitlab pipeline started

Started pipeline #28427295

dd-devflow[bot] avatar Feb 16 '24 15:02 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=auto

chouetz avatar Feb 28 '24 09:02 chouetz

:steam_locomotive: Gitlab pipeline started

Started pipeline #29100684

dd-devflow[bot] avatar Feb 28 '24 09:02 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on

chouetz avatar Mar 06 '24 09:03 chouetz

:rotating_light: Devflow

POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/datadog-agent/pipeline: 500 {message: 500 Internal Server Error}

Details
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: d046d38b-ee70-4d6e-b083-3105a10f873f_27, runID: be77b20b-4ee6-4db4-8e98-ea06cd7cc958, initiatedEventID: 27, startedEventID: 28): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: be77b20b-4ee6-4db4-8e98-ea06cd7cc958_14, runID: f46052c4-00c7-4814-8730-dee28ac9fc34, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 8, startedEventID: 9, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/datadog-agent/pipeline: 500 {message: 500 Internal Server Error} (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #ci-interfaces!

dd-devflow[bot] avatar Mar 06 '24 09:03 dd-devflow[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on

chouetz avatar Mar 11 '24 13:03 chouetz

:steam_locomotive: Gitlab pipeline started

Started pipeline #29888120

dd-devflow[bot] avatar Mar 11 '24 13:03 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30562281 --os-family=ubuntu

pr-commenter[bot] avatar Mar 14 '24 11:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 365ca118-a3fd-48cd-9359-707046bea44a Baseline: eef61a70604308c373b24367bfd44cbb9d3424f7 Comparison: 78d6e9b083c9dc418d30eb11313aae376c3fa308

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +57.48 [+49.61, +65.35]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +57.48 [+49.61, +65.35]
idle memory utilization +4.07 [+4.04, +4.11]
process_agent_real_time_mode memory utilization +3.84 [+3.80, +3.88]
file_tree memory utilization +3.42 [+3.35, +3.50]
process_agent_standard_check_with_stats memory utilization +3.23 [+3.19, +3.27]
process_agent_standard_check memory utilization +3.01 [+2.96, +3.05]
basic_py_check % cpu utilization +0.11 [-2.28, +2.50]
trace_agent_json ingress throughput +0.02 [-0.02, +0.05]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
tcp_syslog_to_blackhole ingress throughput -0.11 [-0.19, -0.03]
otel_to_otel_logs ingress throughput -0.62 [-1.09, -0.15]
uds_dogstatsd_to_api_cpu % cpu utilization -1.41 [-4.27, +1.46]
pycheck_1000_100byte_tags % cpu utilization -1.75 [-6.51, +3.02]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 14 '24 12:03 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable DEPLOY_AGENT=true --variable RUN_UNIT_TESTS=on

chouetz avatar Mar 15 '24 10:03 chouetz

:steam_locomotive: Gitlab pipeline started

Started pipeline #30167322

dd-devflow[bot] avatar Mar 15 '24 10:03 dd-devflow[bot]

[Fast Unit Tests Report]

On pipeline 30898022 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

/merge

chouetz avatar Mar 27 '24 09:03 chouetz

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 29m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 27 '24 09:03 dd-devflow[bot]