datadog-agent
datadog-agent copied to clipboard
Send ECS task lifecycle events
What does this PR do?
Based on https://github.com/DataDog/datadog-agent/pull/21836, this PR updates lifecycle event check to send ecs task events
https://github.com/DataDog/agent-payload/pull/282
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
- [ ] If known, an appropriate milestone has been selected; otherwise the
Triagemilestone is set. - [ ] Use the
major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [ ] A release note has been added or the
changelog/no-changeloglabel has been applied. - [ ] Changed code has automated tests for its functionality.
- [ ] Adequate QA/testing plan information is provided. Except if the
qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied. - [ ] At least one
team/..label has been applied, indicating the team(s) that should QA this change. - [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [ ] If applicable, the
need-change/operatorandneed-change/helmlabels have been applied. - [ ] If applicable, the
k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature. - [ ] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 442d8f06-352b-4628-b697-bf405ee5f536 Baseline: b4f0a172d309dc5b7689bc9674e0487e4fd0cf1b Comparison: 3b5863b9ff336e362f19f45910a8154f2e09d637
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.27 | [-6.59, +6.04] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +3.48 | [-1.62, +8.59] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.81 | [+0.15, +1.47] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.47 | [+0.43, +0.52] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.06, +0.06] |
| ➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.07, +0.04] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.03 | [-0.05, -0.02] |
| ➖ | file_tree | memory utilization | -0.13 | [-0.21, -0.04] |
| ➖ | process_agent_standard_check | memory utilization | -0.19 | [-0.24, -0.15] |
| ➖ | file_to_blackhole | % cpu utilization | -0.27 | [-6.59, +6.04] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.31 | [-3.14, +2.52] |
| ➖ | idle | memory utilization | -0.31 | [-0.36, -0.27] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.50 | [-0.55, -0.46] |
| ➖ | basic_py_check | % cpu utilization | -0.54 | [-2.87, +1.78] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.70 | [-0.79, -0.62] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=30366201 --os-family=ubuntu
Regression Detector
Regression Detector Results
Run ID: 4ce1287e-4437-4f10-b693-25cbcb669fe6 Baseline: b4d74ede603677d91f61c418494c7d3bcf3b9c17 Comparison: bfa6691240ffa7fa5a14b6916347e9a391bd80bb
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | -0.67 | [-6.94, +5.60] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | +0.60 | [+0.55, +0.64] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | +0.47 | [+0.42, +0.51] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.36 | [-2.32, +3.05] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.35 | [+0.31, +0.39] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.15 | [-0.27, +0.57] |
| ➖ | process_agent_standard_check | memory utilization | +0.11 | [+0.07, +0.15] |
| ➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.02 | [-0.03, -0.01] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.02 | [-0.05, +0.01] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.29 | [-0.38, -0.20] |
| ➖ | file_tree | memory utilization | -0.36 | [-0.46, -0.25] |
| ➖ | basic_py_check | % cpu utilization | -0.43 | [-2.93, +2.07] |
| ➖ | file_to_blackhole | % cpu utilization | -0.67 | [-6.94, +5.60] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.66 | [-6.51, +3.18] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue
Pull request added to the queue.
There are 2 builds ahead! (estimated merge in less than 28m)
Use /merge -c to cancel this operation!