datadog-agent
datadog-agent copied to clipboard
Add HTTPS support to fakeintake client
What does this PR do?
Add HTTPS support to fakeintake client
Motivation
Support same endpoint for Agent and test client.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Use the fakeintake client to target an HTTPS fakeintake.
Reviewer's Checklist
- [x] If known, an appropriate milestone has been selected; otherwise the
Triage
milestone is set. - [x] Use the
major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote. - [x] A release note has been added or the
changelog/no-changelog
label has been applied. - [x] Changed code has automated tests for its functionality.
- [x] Adequate QA/testing plan information is provided. Except if the
qa/skip-qa
label, with required eitherqa/done
orqa/no-code-change
labels, are applied. - [x] At least one
team/..
label has been applied, indicating the team(s) that should QA this change. - [x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
- [x] If applicable, the
need-change/operator
andneed-change/helm
labels have been applied. - [x] If applicable, the
k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature. - [x] If applicable, the config template has been updated.
Bloop Bleep... Dogbot Here
Regression Detector Results
Run ID: 89fd2fca-767a-401a-a825-48d3efe3ab8a Baseline: a21f2f0f835a2417017dccd34dc1482c03efc66d Comparison: 162820667e80c74c741a31e5f19f0cceb4e06d1f Total CPUs: 7
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true
are ignored.
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | idle | memory utilization | -0.16 | [-0.19, -0.14] |
➖ | file_tree | memory utilization | -0.83 | [-0.92, -0.73] |
➖ | file_to_blackhole | % cpu utilization | -1.22 | [-7.74, +5.29] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.79 | [+0.73, +0.85] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.18 | [+0.14, +0.23] |
➖ | process_agent_real_time_mode | memory utilization | +0.16 | [+0.12, +0.19] |
➖ | process_agent_standard_check | memory utilization | +0.11 | [+0.06, +0.16] |
➖ | trace_agent_json | ingress throughput | +0.06 | [+0.03, +0.09] |
➖ | trace_agent_msgpack | ingress throughput | +0.05 | [+0.03, +0.07] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.06, +0.06] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.04, +0.04] |
➖ | idle | memory utilization | -0.16 | [-0.19, -0.14] |
➖ | file_tree | memory utilization | -0.83 | [-0.92, -0.73] |
➖ | file_to_blackhole | % cpu utilization | -1.22 | [-7.74, +5.29] |
➖ | otel_to_otel_logs | ingress throughput | -2.05 | [-2.76, -1.33] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".