datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CI/Tooling] Remove hardened_runtime argument for the `agent.omnibus-build` invoke task

Open amenasria opened this issue 1 year ago • 3 comments

What does this PR do?

This PR removes the hardened_runtimes flag in the agent.omnibus-build invoke task.

Motivation

According to the comments it was used to build the Agent on MacOS < 10.13.6. According to the Agent Installation Instructions: Agent v7.38 is the last release to support macOS 10.13. (we're in 7.50 rn).

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

amenasria avatar Dec 14 '23 13:12 amenasria

The MacOS build job will fail because the --hardened-runtime is used there.

amenasria avatar Dec 14 '23 13:12 amenasria

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 022d5497-72e9-483a-97a7-a1b0cee66574 Baseline: cbb18309de600a7e1d9883cb010f240198aca2ed Comparison: e1d87013062ef4359f786c17b1a518159f59e89f Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • idle

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput -1.57 [-2.28, -0.87] 99.97%

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
file_to_blackhole egress throughput +0.02 [-6.15, +6.18] 0.38%
dogstatsd_string_interner_8MiB_100k ingress throughput +0.00 [-0.00, +0.00] 9.83%
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.00, +0.00] 0.00%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00] 0.00%
trace_agent_json ingress throughput +0.00 [-0.01, +0.01] 0.00%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.00, +0.00] 0.00%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.00, +0.00] 0.00%
file_tree egress throughput -0.16 [-1.96, +1.63] 11.99%
tcp_syslog_to_blackhole ingress throughput -1.22 [-1.28, -1.16] 100.00%
otel_to_otel_logs ingress throughput -1.57 [-2.28, -0.87] 99.97%

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Dec 14 '23 15:12 pr-commenter[bot]

I like the way you broke down the deprecation, on it !

amenasria avatar Dec 15 '23 10:12 amenasria