AMLII-1233: Adds basic py check in regression detector env

[scottopell]

What does this PR do?

Adds a regression detector experiment that runs a python check.

Motivation

No current scenarios are running python checks, this adds something even if its the simplest possible check.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

• [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• [ ] A release note has been added or the changelog/no-changelog label has been applied.
• [ ] Changed code has automated tests for its functionality.
• [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
• [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
• [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• [ ] If applicable, the config template has been updated.

[scottopell]

Another candidate for a python check that could be useful, the one from https://github.com/DataDog/datadog-agent/pull/21424

[scottopell]

Deferring this until Agent CI uses a version of lading with this change https://github.com/DataDog/lading/pull/774 (bug is: when no generators are specified, lading exits too early)

[scottopell]

lading 0.20.4 is now the version used in this repo, once mergefreeze is lifted I'll merge this. ref https://github.com/DataDog/datadog-agent/pull/21577/files

[pr-commenter[bot]]

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 044fbaeb-58a5-4cec-97db-c12e3a5c7faa Baseline: 091536ce2affeb146584d17a319ab9a5103c7ea9 Comparison: 9725feeaa1f48f853354eb935c76ecfe2407795c Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Experiments with missing or malformed data

• basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.35	[-6.22, +6.93]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	tcp_syslog_to_blackhole	ingress throughput	+0.52	[+0.46, +0.58]
➖	file_to_blackhole	% cpu utilization	+0.35	[-6.22, +6.93]
➖	process_agent_real_time_mode	memory utilization	+0.23	[+0.19, +0.27]
➖	process_agent_standard_check_with_stats	memory utilization	+0.23	[+0.19, +0.26]
➖	idle	memory utilization	+0.16	[+0.11, +0.20]
➖	trace_agent_json	ingress throughput	+0.05	[+0.01, +0.08]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.01, -0.00]
➖	process_agent_standard_check	memory utilization	-0.31	[-0.35, -0.27]
➖	file_tree	memory utilization	-0.52	[-0.62, -0.42]
➖	otel_to_otel_logs	ingress throughput	-0.70	[-1.29, -0.12]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-2.83	[-4.22, -1.44]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[scottopell]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue

Pull request added to the queue.

There are 5 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!