What does this PR do?

Removes the --flavors (list) option of inv test, and replaces it with the --flavor (string) option, that only allows specifying one flavor. Removes code to handle multiple flavors. Removes deprecated --skip-linters option from inv test. Simplifies test and lint results processing: we don't need a complex per-phase and per-flavor dictionary anymore, since each task only targets one flavor, and does either linting or testing, not both.

Motivation

Simplify the inv test task. I believe there there are no uses of inv test with multiple flavors specified, so it is not worth keeping overly complex code for this feature.

Additional Notes

n/a

Possible Drawbacks / Trade-offs

n/a

Describe how to test/QA your changes

Verify that all lint and test tasks in CI still work, and do test what they are expected to test.

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[x] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[x] If applicable, the config template has been updated.

Dec 06 '23 14:12 KSerrania

Everything looked reasonable to me, did we leave the flag "deprecated" for long enough (if we have any sort of policy around that...)

It has been here since November 2023. I'll merge this during the first week of February, so I think that was enough advance notice.

Jan 08 '24 13:01 KSerrania

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e007d0b0-7aaf-40a3-9207-0e887ce5ef1b Baseline: abe3cd78b6ebec2c0e569ca701ce02784495069e Comparison: e3ee7021d0fe65d663004373c7d5e46fe1d38ff8 Total CPUs: 7

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.46	[-6.12, +7.04]
➖	file_tree	memory utilization	+0.46	[+0.39, +0.52]
➖	idle	memory utilization	-0.45	[-0.47, -0.43]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	+0.46	[-6.12, +7.04]
➖	file_tree	memory utilization	+0.46	[+0.39, +0.52]
➖	process_agent_standard_check_with_stats	memory utilization	+0.07	[+0.03, +0.11]
➖	trace_agent_json	ingress throughput	+0.02	[-0.01, +0.05]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.03, +0.03]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.05, +0.05]
➖	trace_agent_msgpack	ingress throughput	-0.02	[-0.05, +0.02]
➖	idle	memory utilization	-0.45	[-0.47, -0.43]
➖	process_agent_standard_check	memory utilization	-0.49	[-0.53, -0.45]
➖	process_agent_real_time_mode	memory utilization	-0.73	[-0.77, -0.70]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.89	[-0.94, -0.83]
➖	otel_to_otel_logs	ingress throughput	-1.40	[-2.13, -0.68]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.44	[-2.87, -0.00]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Jan 08 '24 14:01 pr-commenter[bot]

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on

Apr 23 '24 12:04 KSerrania

:steam_locomotive: Gitlab pipeline started

Started pipeline #32686191

Apr 23 '24 12:04 dd-devflow[bot]

/merge

Apr 23 '24 15:04 KevinFairise2

:steam_locomotive: MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

Apr 23 '24 15:04 dd-devflow[bot]