What does this PR do?

Adds EnvironmentFile to all systemd unit files
Same as https://github.com/DataDog/datadog-agent/pull/16017 but applied to other Agent services

Motivation

Trace Agent did not pickup envvvars from /etc/datadog-agent/environment

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

create file /etc/datadog-agent/environment with content

DD_APM_NON_LOCAL_TRAFFIC=true

Restart datadog-agent-trace
Check if trace-agent is listening on all interfaces instead of localhost: netstat -plant |grep trace-agent
- expected: tcp6 0 0 :::8126 :::* LISTEN PID/trace-agent

Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Nov 10 '23 03:11 ian28223

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: e47460bf-7257-4dad-ad96-0b3246e1aa42 Baseline: 4bf26c276f788b974939b86c00cda694b907007e Comparison: 3282e52ebb659b1f88cf16da971eeca4962ea5d0 Total CPUs: 7

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Experiments with missing or malformed data

basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_to_blackhole	% cpu utilization	-0.25	[-6.80, +6.30]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.72	[+0.27, +3.16]
➖	file_tree	memory utilization	+0.22	[+0.14, +0.30]
➖	process_agent_standard_check_with_stats	memory utilization	+0.15	[+0.12, +0.18]
➖	process_agent_standard_check	memory utilization	+0.13	[+0.09, +0.17]
➖	process_agent_real_time_mode	memory utilization	+0.07	[+0.04, +0.10]
➖	trace_agent_msgpack	ingress throughput	+0.03	[+0.02, +0.04]
➖	idle	memory utilization	+0.02	[-0.00, +0.05]
➖	trace_agent_json	ingress throughput	+0.01	[-0.02, +0.05]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.00, +0.00]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]
➖	file_to_blackhole	% cpu utilization	-0.25	[-6.80, +6.30]
➖	otel_to_otel_logs	ingress throughput	-0.41	[-0.99, +0.18]
➖	tcp_syslog_to_blackhole	ingress throughput	-0.52	[-0.58, -0.46]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Feb 19 '24 00:02 pr-commenter[bot]

[Fast Unit Tests Report]

On pipeline 41205286 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Aug 08 '24 10:08 agent-platform-auto-pr[bot]