datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Add integrations_core_ref as workflow inputs

Open chouetz opened this issue 2 years ago • 1 comments

What does this PR do?

Add integrations_core_ref as mascos workflow inputs

Motivation

Integrations-core pipeline launches a datadog-agent build as subsequent pipeline with the PR branch as integrations-core reference. We need to pass this information to the macos-build to validate integrations-core on this job as well

Additional Notes

Depends on https://github.com/DataDog/datadog-agent-macos-build/pull/155

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

chouetz avatar Oct 26 '23 15:10 chouetz

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ef926143-505a-4a52-9c4b-ad1b9b807c11 Baseline: 7b4702d897b65d2c0333c3e650574277fc629dd7 Comparison: 5f9cfaa5d704a5eefa6ab0d4d1b60544aac9f6ae Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • basic_py_check

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -2.30 [-8.82, +4.23]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +1.44 [+0.84, +2.05]
process_agent_standard_check_with_stats memory utilization +0.43 [+0.38, +0.48]
idle memory utilization +0.34 [+0.31, +0.37]
tcp_syslog_to_blackhole ingress throughput +0.29 [+0.22, +0.35]
trace_agent_json ingress throughput +0.04 [+0.01, +0.07]
process_agent_standard_check memory utilization +0.02 [-0.04, +0.08]
trace_agent_msgpack ingress throughput +0.01 [-0.01, +0.02]
process_agent_real_time_mode memory utilization +0.01 [-0.02, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api_cpu % cpu utilization -0.04 [-1.46, +1.39]
file_tree memory utilization -0.15 [-0.23, -0.07]
file_to_blackhole % cpu utilization -2.30 [-8.82, +4.23]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Oct 26 '23 18:10 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30558830 --os-family=ubuntu

pr-commenter[bot] avatar Mar 21 '24 14:03 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 62c89d4e-e40a-4828-b76a-98d7783a06c8 Baseline: 02e11347e6f70a13573c5affa6329bc263cdfdf3 Comparison: a1161422d649d3f7fa45d4a6250c2de4191c6634

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.79 [-2.66, +10.24]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +3.79 [-2.66, +10.24]
uds_dogstatsd_to_api_cpu % cpu utilization +2.76 [-0.02, +5.53]
pycheck_1000_100byte_tags % cpu utilization +1.53 [-3.41, +6.47]
process_agent_standard_check memory utilization +0.45 [+0.42, +0.48]
process_agent_standard_check_with_stats memory utilization +0.35 [+0.31, +0.38]
process_agent_real_time_mode memory utilization +0.15 [+0.12, +0.18]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.04, +0.01]
trace_agent_json ingress throughput -0.02 [-0.07, +0.02]
otel_to_otel_logs ingress throughput -0.12 [-0.56, +0.33]
file_tree memory utilization -0.20 [-0.30, -0.11]
tcp_syslog_to_blackhole ingress throughput -0.28 [-0.36, -0.19]
idle memory utilization -0.34 [-0.37, -0.31]
basic_py_check % cpu utilization -2.79 [-5.10, -0.49]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Mar 21 '24 15:03 pr-commenter[bot]

/merge

chouetz avatar Mar 22 '24 09:03 chouetz

:steam_locomotive: MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 22 '24 09:03 dd-devflow[bot]

:steam_locomotive: MergeQueue

Added to the queue.

There are 2 builds ahead of this PR! (estimated merge in less than 28m)

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Mar 22 '24 10:03 dd-devflow[bot]