datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[WIP] Use agent snmp configuration (network addresses) for the integrated snmpwalk

Open HadhemiDD opened this issue 3 years ago • 0 comments

What does this PR do?

The current behaviour of the integrated snmpwalk command only recognizes IP addresses explicitly mentioned under the integration file, if the IP address is a part of a network/subnet under the Integration file or in the main file, the integrated snmpwalk won't be able to load its configuration and pass it along as options. The customer would still have to manually insert the IP address and all options required to have the output. The purpose of this PR is to make the integrated snmpwalk command load any IP addresses that are a part of network addresses (either under the integration file or the main file).

Motivation

This is the continuation of this PR: https://github.com/DataDog/datadog-agent/pull/13779

Additional Notes

Nothing for now.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

HadhemiDD avatar Oct 14 '22 13:10 HadhemiDD