datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Fix missing tags on the `kubernetes_state.cronjob.complete` service check

Open L3n41c opened this issue 2 years ago • 0 comments

What does this PR do?

Fix missing tags on the kubernetes_state.cronjob.complete service check.

Motivation

Fix bug.

Additional Notes

Labels join was broken because we were using a wrong label key.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Create a CronJob with unified service tagging and/or recommended Kubernetes labels.

Check that, before this patch, the corresponding tags were appearing on the kubernetes_state.cronjob.on_schedule_check service check but not on the kubernetes_state.cronjob.complete one.

With this patch, the corresponding tags must appear on both service checks.

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

L3n41c avatar Oct 11 '22 19:10 L3n41c