datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

add http monitor tests

Open guyarb opened this issue 3 years ago • 0 comments

What does this PR do?

  • The PR adds a UT for the HTTP monitoring package.
    • The first scenario is slow response from a server with different "agent" configuration for cleaning IDLE connections.
    • The second scenario is requests & responses with actual bodies
    • The third scenario is incomplete requests, which we make sure don't deny us from capturing other requests
  • In the PR I had to convert 2 hard coded values into configurable values (http_map_cleaner_interval_in_s, http_idle_connection_ttl_in_s), for both of them the hard coded values have become the default values.

Motivation

Testing a complex scenario for the eBPF agent.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

guyarb avatar Aug 14 '22 15:08 guyarb