datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[network/go] fixup inv -e system-probe.generate-lookup-tables

Open nplanel opened this issue 2 years ago • 1 comments

What does this PR do?

Looking at our QA card for https://github.com/DataDog/datadog-agent/pull/10039 https://github.com/DataDog/datadog-agent/pull/12897 Found that inv -e system-probe.generate-lookup-tables gotls/lookup table generation was working correctly

It's a minor issue not affecting 7.38 runtime as the generated files are the same

original error go generate ./pkg/network/http/gotls/lookup/main.go package command-line-arguments imports github.com/DataDog/datadog-agent/pkg/network/go/bininspect: build constraints exclude all Go files in /home/nplanel/dd/datadog-agent/pkg/network/go/bininspect

files containing build linux_bpf tag dependency

  • pkg/network/go/bininspect/inspect.go
  • pkg/network/http/gotls/lookup/luts.go

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

nplanel avatar Aug 09 '22 08:08 nplanel

@nplanel I think this can wait for 7.40 since it doesn't affect any production code.

brycekahle avatar Aug 09 '22 17:08 brycekahle