datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] Generate .length field for string fields

Open lebauce opened this issue 3 years ago • 2 comments
trafficstars

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • [ ] If applicable, the config template has been updated.

lebauce avatar Jul 27 '22 08:07 lebauce

I'm not sure I understand why len(container.id) was not possible. This solution seems to add a lot of noise in the documentation and a lot of noise in the generation template

paulcacheux avatar Jul 27 '22 08:07 paulcacheux

Can you rebase, and restrict the length field on specific fields only

paulcacheux avatar Aug 10 '22 15:08 paulcacheux