datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[network] tests openssl/gnutls backend for curl

Open nplanel opened this issue 2 years ago • 1 comments

What does this PR do?

Adding more https tests by testing openssl/gnutls against curl and wget

Describe how to test/QA your changes

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [ ] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the config template has been updated.

nplanel avatar Jun 07 '22 13:06 nplanel

Let's add something so that curl is only downloaded and built once in local dev environments. Maybe check the packages curl has been built with before attempting.

brycekahle avatar Jul 20 '22 09:07 brycekahle