datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

pkg/trace/api: Lower idle connection timeout for instrumentation telemetry

Open paullegranddc opened this issue 3 years ago • 3 comments
trafficstars

What does this PR do?

Same as this PR but for instrumentation telemetry https://github.com/DataDog/datadog-agent/pull/10806

Reduces the agent's idle connection timeout to 47 seconds for telemetry proxy.

Motivation

See the inline comment

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

  • When enabling this system_test for python, or java, it is flaky https://github.com/DataDog/system-tests/blob/c399fefb2289fe186a0481e24658a25955053d3a/tests/test_telemetry.py#L20 and fails with 502. The errors seem to not happen anymore using an agent image built from this commit.
  • Datadog's java services are seeing a lot of errors related to telemetry 502s, which should be fixed by this.

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • [x] A release note has been added or the changelog/no-changelog label has been applied.
  • [ ] Changed code has automated tests for its functionality.
  • [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • [x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
  • [ ] If applicable, the config template has been updated.

paullegranddc avatar May 03 '22 13:05 paullegranddc

CLA assistant check
All committers have signed the CLA.

bits-bot avatar May 03 '22 13:05 bits-bot

Sure, added a QA section

paullegranddc avatar Oct 06 '22 12:10 paullegranddc

@katiehockman Which milestone should I put on the PR?

paullegranddc avatar Oct 06 '22 15:10 paullegranddc