dd-agent recipe is not idempotent

[limitusus]

dd-agent recipe always evaluates ruby_block 'include system-probe' even after the first run, with rendered template placed on the host. Chef recipes all should be idempotent, so most of conditionals should be evaluated as guard clauses. What do you think of moving conditionals in ruby_block's only_if clause or template's only_if ?

I'm afraid of you need to fix current sysprobe tests somehow, because the current tests assumes sysprobe implies dd-agent was already installed.

[julien-lebot]

Hey @limitusus, thanks for reporting this issue. We have released v4.5.0 of the cookbook which contains a fix that should address it (see #736). Could you please let us know if the changes are satisfactory ? Thanks 👍

[limitusus]

Sorry for late reply. I confirmed it fixed. Thank you so much 😄