Let the agent set the default hostname

[remh]

The hostname logic in the agent is more reliable

Defaulting to the node name can create some issues as the chef node name can be based on the ip of the machine that could get recycled.

[miketheman]

Will the agent detect a chef node name?

[remh]

It will use the instanceid in case of EC2/Google Cloud, then default on the machine hostname.

[remh]

cc: @DBLaw

[miketheman]

@remh Thanks, I think I get it. I think this might have to wait until 3.0.0, as the change removes the default setting of an attribute to nil, something that was defined in the CVP as a major change. Ref: http://chef-community.github.io/cvp/

Considering that anyone wanting to "remove" this can override the attribute with their choice, using node.fqdn, node.hostname or any other value, or even apply a node.rm('datadog', 'hostname') (ref) as a workaround, I think we should leave this until the next Major release.