ansible-datadog icon indicating copy to clipboard operation
ansible-datadog copied to clipboard

"Download current RPM key" task runs invariably.

Open thetic opened this issue 1 year ago • 3 comments

Downloads to /tmp/ are not idempotent.

https://github.com/DataDog/ansible-datadog/blob/d752114368da9cae1c86340f2e3f1ac3448e945a/tasks/pkg-redhat.yml#L28-L32

thetic avatar Mar 01 '23 19:03 thetic

rpm_key can accept a URL rather than a local path.

thetic avatar Mar 01 '23 19:03 thetic

Hi, Sorry for the inconvenience but we had to revert #475 because it created a regression. Merging this PR broke all the playbooks ran with variables datadog_yum_gpgkey_* set to local file with file:/// prefix, because rpm_key module does not allow importing key on the local file system with file:/// prefix.

We will look for another solution that would definitely solve this issue without breaking key import when using path to keys on the local file system.

KevinFairise2 avatar Jul 17 '23 11:07 KevinFairise2

Why not just change the download destination to a non-tmp location or at least remove the force?

eightnoneone avatar Nov 03 '23 22:11 eightnoneone