ansible-datadog icon indicating copy to clipboard operation
ansible-datadog copied to clipboard

add integration installation changed_when reporting

Open camjay opened this issue 2 years ago • 2 comments

check for existing version of integrations, don't report changes if integration(s) install is unchanged add quotes and re-order modified task params for consistency fix spelling errors

camjay avatar Nov 15 '21 23:11 camjay

Hi! Thanks for sending the PR. While this seems to work for now, it might break if the output string changed or became localized. I think it would be better to first run a loop with agent integration show <name> -q which will fail (if the integration is not present) or echo current version (if it is present). Then we could only install integrations for which show failed or returned a version different than what is set in the playbook.

Does that sound reasonable? I can look into it if you don't have time to modify this PR.

bkabrda avatar Nov 24 '21 13:11 bkabrda

@bkabrda I've modified it based on your feedback. Let me know if the spelling fixes should be split out into a separate PR.

camjay avatar Dec 31 '21 00:12 camjay