Issues/3653 arbitrary aws tags

[Hexotical]

Changelog Entry

To be copied to the draft changelog by merger:

Address issue 3653 via adding a new environment variable which takes a json dictionary of tags to apply when creating buckets, adds testing for util functions to gitlab

Reviewer Checklist

• [ ] Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
  • [ ] If it is coming from an external repo, make sure to pull it in for CI with:

    contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
    

  • [ ] If there is no associated issue, create one.
• [ ] Read through the code changes. Make sure that it doesn't have:
  • [ ] Addition of trailing whitespace.
  • [ ] New variable or member names in camelCase that want to be in snake_case.
  • [ ] New functions without type hints.
  • [ ] New functions or classes without informative docstrings.
  • [ ] Changes to semantics not reflected in the relevant docstrings.
  • [ ] New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
  • [ ] New features without tests.
• [ ] Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
• [ ] Finish the review with an overall description of your opinion.

Merger Checklist

• [ ] Make sure the PR passes tests.
• [ ] Make sure the PR has been reviewed since its last modification. If not, review it.
• [ ] Merge with the Github "Squash and merge" feature.
  • [ ] If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
• [ ] Copy its recommended changelog entry to the Draft Changelog.
• [ ] Append the issue number in parentheses to the changelog entry.

[adamnovak]

@DailyDreaming It looks like right now toil launch-cluster has a --tag option to let you add tags to the things it makes, across all services, and this new variable is applied to AWS Job Store buckets (and not yet merged in with --tags by launch-cluster).

I'm not sure we need support for different tags for different services. We might want to let the environment variable work as a fallback for --tag before we merge, but I'd be happy with just one set of tags across services, at least for now.

[adamnovak]

@Hexotical What do you think makes the most sense to do from your perspective?

[DailyDreaming]

@DailyDreaming It looks like right now toil launch-cluster has a --tag option to let you add tags to the things it makes, across all services, and this new variable is applied to AWS Job Store buckets (and not yet merged in with --tags by launch-cluster).

I'm not sure we need support for different tags for different services. We might want to let the environment variable work as a fallback for --tag before we merge, but I'd be happy with just one set of tags across services, at least for now.

Alright, I'm on board with that. I was thinking it'd be easier to implement now and not have to deal with backwards compatibility in the future, but both methods of tagging would be fairly obvious, so just having one tag set makes sense.

[Hexotical]

@adamnovak #4226 seems to want individual tagging for each service, will add this